0005176: vehumet trees vault scriptet - Dungeon Crawl Stone Soup Tracker

(0016540)
evilmike (developer)
2012-01-06 07:08

This doesn't seem to fully work. Vehumet doesn't speak if you enter the ring of trees. They do burn properly though, the only problem I can find is that the message won't show.

(0016543)
jeffqyzt (reporter)
2012-01-06 08:04

Should the phrase "Vehumet promises to free you, if you'll worship him." be replaced by a gender neutral construction, per Crawl guidelines? Perhaps something like:

In a voice like roaring flames, Vehumet offers to free you in exchange for your pious devotion to destruction.

(0016544)
evilmike (developer)
2012-01-06 08:36

Yes, gods are officially gender-neutral in crawl.

(0016546)
dk (reporter)
2012-01-06 11:28

Should now be fixed.

Somehow a # got missing in the lua script. I suspect Xom to have removed it while uploading the file.

I also changed the message text like suggested by jeffqyzt. Since English is not my native language, it's always hard for me to come up with some flavourful in-game text.

(0016550)
evilmike (developer)
2012-01-06 17:04

Seems if you burn one of the trees it still counts 16. I guess if the tree is destroyed the marker isn't. The feat_change triggerer probably will help here, although I haven't tried to fix this myself (this is just the first thing I would try). If you want to give it a shot, feel free to reupload. Otherwise I'll get it working myself when I have some time.

(0016556)
dk (reporter)
2012-01-06 20:57

I have some problems getting the feat_change trigger to work. I asked on the mailing list and on IRC, but no response so far. There's also no example code around, at least I did not find any. Currently I have this http://pastebin.com/CU15aVy5 [^] but I always get an error. Can't activate, triggerable removed. I'm just trying to find a way to set a variable/flag if one of those trees gets removed before the player enters the square of trees.

(0016559)
dk (reporter)
2012-01-07 01:09

So, I did a complete rewrite, and now it works. I had to put it all in one function. I changed the player_los trigger for a turn trigger, but that does not make a difference I think. One thing that bothers me is that I have to use one function with three different triggers used by 17 markers, but was not able to come up with a nicer solution. Anyway, it should work now as intended.

(0016561)
evilmike (developer)
2012-01-07 06:16

Thanks.

(0016577)
evilmike (developer)
2012-01-08 05:42
edited on: 2012-01-08 05:44

I'm reopening this, since there is still problems with the vault (see: https://crawl.develz.org/mantis/view.php?id=5184 [^] )

I was able to prevent the crash issue by editing it slightly, but there are still some other strange issues. Try placing the vault, going to the next level, returning to the level, and then entering the circle of trees. I'm uploading the non-crashing version here so you can look at it.

(0016582)
dk (reporter)
2012-01-08 14:42

OK, this new version I uploaded seems to work fine. I did find out about 'dgn.persist', which allowed me to split the function up again into 3 functions. Still don't know why the previous version failed on level change, but it was hacky anyway.

Are there some things to consider using 'dgn.persist'? It seems to be the only way to share data between different triggers.

(0016603)
evilmike (developer)
2012-01-09 22:39

Alright then, tested it extensively offline and it works fine now, although I'm paranoid about this vault now. Thanks for the fixed version!

(0016608)
dk (reporter)
2012-01-10 14:20

> I'm paranoid about this vault now.

Me too :-)

There seems to be an issue with the player_los-trigger, I filed a report here: https://crawl.develz.org/mantis/view.php?id=5196 [^]

Issue History
Date Modified	Username	Field	Change
2012-01-05 16:59	dk	New Issue
2012-01-05 16:59	dk	File Added: vehumet_trees.des
2012-01-06 04:24	evilmike	Status	new => assigned
2012-01-06 04:24	evilmike	Assigned To	=> evilmike
2012-01-06 07:08	evilmike	Note Added: 0016540
2012-01-06 07:08	evilmike	Status	assigned => feedback
2012-01-06 08:04	jeffqyzt	Note Added: 0016543
2012-01-06 08:36	evilmike	Note Added: 0016544
2012-01-06 11:24	dk	File Added: vehumet_trees_fixed.des
2012-01-06 11:28	dk	Note Added: 0016546
2012-01-06 11:28	dk	Status	feedback => acknowledged
2012-01-06 17:04	evilmike	Note Added: 0016550
2012-01-06 20:57	dk	Note Added: 0016556
2012-01-07 01:02	dk	File Added: vehumet_trees_fixed_final.des
2012-01-07 01:09	dk	Note Added: 0016559
2012-01-07 06:16	evilmike	Note Added: 0016561
2012-01-07 06:16	evilmike	Status	acknowledged => resolved
2012-01-07 06:16	evilmike	Fixed in Branch	=> 0.10 development branch
2012-01-07 06:16	evilmike	Resolution	open => done
2012-01-07 10:52	dk	Status	resolved => closed
2012-01-08 05:42	evilmike	Assigned To	evilmike =>
2012-01-08 05:42	evilmike	Note Added: 0016577
2012-01-08 05:42	evilmike	Status	closed => feedback
2012-01-08 05:42	evilmike	Resolution	done => reopened
2012-01-08 05:42	evilmike	File Deleted: vehumet_trees_fixed.des
2012-01-08 05:43	evilmike	File Deleted: vehumet_trees.des
2012-01-08 05:43	evilmike	File Added: vehumet_trees_edited.des
2012-01-08 05:44	evilmike	Note Edited: 0016577
2012-01-08 14:36	dk	File Added: vehumet_trees_new.des
2012-01-08 14:42	dk	Note Added: 0016582
2012-01-08 14:43	dk	Status	feedback => acknowledged
2012-01-09 22:39	evilmike	Note Added: 0016603
2012-01-09 22:39	evilmike	Status	acknowledged => resolved
2012-01-09 22:39	evilmike	Resolution	reopened => done
2012-01-09 22:39	evilmike	Assigned To	=> evilmike
2012-01-10 14:20	dk	Note Added: 0016608
2012-01-10 14:20	dk	Status	resolved => closed

Notes
(0016540) evilmike (developer) 2012-01-06 07:08	This doesn't seem to fully work. Vehumet doesn't speak if you enter the ring of trees. They do burn properly though, the only problem I can find is that the message won't show.

(0016543) jeffqyzt (reporter) 2012-01-06 08:04	Should the phrase "Vehumet promises to free you, if you'll worship him." be replaced by a gender neutral construction, per Crawl guidelines? Perhaps something like: In a voice like roaring flames, Vehumet offers to free you in exchange for your pious devotion to destruction.

(0016544) evilmike (developer) 2012-01-06 08:36	Yes, gods are officially gender-neutral in crawl.

(0016546) dk (reporter) 2012-01-06 11:28	Should now be fixed. Somehow a # got missing in the lua script. I suspect Xom to have removed it while uploading the file. I also changed the message text like suggested by jeffqyzt. Since English is not my native language, it's always hard for me to come up with some flavourful in-game text.

(0016550) evilmike (developer) 2012-01-06 17:04	Seems if you burn one of the trees it still counts 16. I guess if the tree is destroyed the marker isn't. The feat_change triggerer probably will help here, although I haven't tried to fix this myself (this is just the first thing I would try). If you want to give it a shot, feel free to reupload. Otherwise I'll get it working myself when I have some time.

(0016556) dk (reporter) 2012-01-06 20:57	I have some problems getting the feat_change trigger to work. I asked on the mailing list and on IRC, but no response so far. There's also no example code around, at least I did not find any. Currently I have this http://pastebin.com/CU15aVy5 [^] but I always get an error. Can't activate, triggerable removed. I'm just trying to find a way to set a variable/flag if one of those trees gets removed before the player enters the square of trees.

(0016559) dk (reporter) 2012-01-07 01:09	So, I did a complete rewrite, and now it works. I had to put it all in one function. I changed the player_los trigger for a turn trigger, but that does not make a difference I think. One thing that bothers me is that I have to use one function with three different triggers used by 17 markers, but was not able to come up with a nicer solution. Anyway, it should work now as intended.

(0016561) evilmike (developer) 2012-01-07 06:16	Thanks.

(0016577) evilmike (developer) 2012-01-08 05:42 edited on: 2012-01-08 05:44	I'm reopening this, since there is still problems with the vault (see: https://crawl.develz.org/mantis/view.php?id=5184 [^] ) I was able to prevent the crash issue by editing it slightly, but there are still some other strange issues. Try placing the vault, going to the next level, returning to the level, and then entering the circle of trees. I'm uploading the non-crashing version here so you can look at it.

(0016582) dk (reporter) 2012-01-08 14:42	OK, this new version I uploaded seems to work fine. I did find out about 'dgn.persist', which allowed me to split the function up again into 3 functions. Still don't know why the previous version failed on level change, but it was hacky anyway. Are there some things to consider using 'dgn.persist'? It seems to be the only way to share data between different triggers.

(0016603) evilmike (developer) 2012-01-09 22:39	Alright then, tested it extensively offline and it works fine now, although I'm paranoid about this vault now. Thanks for the fixed version!

(0016608) dk (reporter) 2012-01-10 14:20	> I'm paranoid about this vault now. Me too :-) There seems to be an issue with the player_los-trigger, I filed a report here: https://crawl.develz.org/mantis/view.php?id=5196 [^]

Relationships