Davion Fuxa wrote:It would help prevent people from wasting Enchant Weapon Scrolls on the wrong weapon
Instead you'll waste more scrolls in the Id game, won't make any net difference really.
Davion Fuxa wrote:it makes Enchant Weapon Scrolls more like Enchant Armour which adds a little bit more to the identification game,
This adds interface consistency which I think is the strongest point in its favour.
Davion Fuxa wrote:and it resolves the Treasure Trove issue.
This depends whether you define that as an "issue" or a "downside of playing a felid".
Davion Fuxa wrote:Barring the above happening, making it so that the Felid can wield weapons in their Teeth for Enchantment purposes or even for Sandblast (holding stones, Tukima's Dance, and Sticks to Snakes would be a beneficial way to adjust the code.
Felids can already wield stones and arrows (and chunks), so it's just weapons that are the problem. And see above; but yeah I don't see anything that's greatly gained by restricting felids from Tukima's. On the other hand I actually really hate the interface of wielding random things, I would personally much rather get rid of non-weapon wielding and make all these things target the inventory, but that's a much bigger change and I'm not sure how it would overall affect the balance of certain spells, cursed items, etc.; and for sublimation it's a bit tricky to manage the interface of whether you self-sublimate or not.
Davion Fuxa wrote:There is no real reason to keep the current code and then think about ways to spend your time coding related code since one more reason for changing it is that it really has no real competing reason against one of the two above changes.
Hmm... maybe you don't realise the time and effort involved in coding what might sound like minor things to people who haven't looked at crawl's code. Anyway I was not even disagreeing with any of the original principles, just pointing out that if changing the scrolls is too complicated, infeasible, or just undesirable, there is a far, far simpler way we could fix the trove issue. Code doesn't write itself, and there is very little here that I'd actually call "broken" about the status quo.