0009838: no warning for trying to fire (throw) through allied summon

Notes
(0029813) bsdbeard (reporter) 2015-11-20 13:36 edited on: 2015-11-20 19:00	The bug is caused by this line of code https://github.com/crawl/crawl/blob/master/crawl-ref/source/misc.cc#l611 [^] Lost two characters to this bug, and was able to reproduce it consistently with a clean .rc file, you must position yourself above-right your summon while aiming at something below the summon as in this screenshot (http://i.imgur.com/4Bwrw5Q.jpg). [^] The game will not ask you for confirmation and you will hit your summon. If you position yourself directly behind, or to the left of the summon, this does not happen and a confirmation is requested. Steps to reproduce: Make HuSu Enter wizmode &E # stop time &mgnoll sergeant # summon enemy &o(stone # give yourself ammo &zice beast # summon ice beast xm # teleport ice beast to match the position in attached screenshot ff or <TAB> # throw stone at gnoll sergeant Expected results: "Really fire through your Ice Beast? Y/N" Observed results: "The stone hits your Ice Beast!" EDIT: This will also happen if you rotate 180 degrees, that is you will stand below-left of the summon like this (http://i.imgur.com/sFZNhsh.jpg). [^]

(0029814) wheals (administrator) 2015-11-20 19:55	Fixed in https://github.com/crawl/crawl/commit/4c9da24b1f35, [^] thanks for reporting and special thanks to bsdbeard/} for the huge help tracking down and fixing the bug!