|Anonymous | Login | Signup for a new account||2019-07-19 08:46 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0008369||[DCSS] Bug Report||minor||always||2014-04-12 00:17||2014-04-14 09:35|
|Status||resolved||Product Branch||0.14 ancient branch|
|Summary||0008369: Build fails with undefined reference to `debug_terp_dlua(CLua&)' if WIZARD is not defined (fix proposal included)|
Building without WIZARD defined fails with the following message:
main.cc:(.text+0x2468): undefined reference to `debug_terp_dlua(CLua&)'
As `debug_terp_dlua` only exists if WIZARD is defined this is no big surprise. I noticed this while porting the game to FreeBSD but the issue seems to be independent of the OS used.
A patch to master, fixing this issue for me, can be found in my github or attached.
: https://github.com/blabber/crawl/commit/944c04bef70238c427607bb57e6a44b23ebe20bb [^]
|Tags||No tags attached.|
|Attached Files||0001-Fix-build-in-cases-where-WIZARD-is-not-defined.patch [^] (908 bytes) 2014-04-12 00:17 [Show Content]|
|I would recommend, instead of disabling the command when WIZARD is off, to make it not dependent on that macro: the clua version of the console doesn't let the player do anything that they couldn't already do in their rcfile. This would involve making unconditional a few members of game_options that are currently in an #ifdef WIZARD .|
|Sounds reasonably but I think that is nothing I can do.|
edited on: 2014-04-14 09:39
Fixed in trunk (0.15-a0-147-g248eb57) and stable (0.14.0-10-g1cb9306); now the clua console (and --no-save) both work in NOWIZARD builds. The rest of blabber's commit (removing the extra break) is in 0.15-a0-150-g6a91247 and 0.14.0-11-g2460d2f.
|2014-04-12 00:17||blabber||New Issue|
|2014-04-12 00:17||blabber||File Added: 0001-Fix-build-in-cases-where-WIZARD-is-not-defined.patch|
|2014-04-12 19:16||neil||Note Added: 0025825|
|2014-04-13 11:38||blabber||Note Added: 0025828|
|2014-04-14 09:34||neil||Note Added: 0025831|
|2014-04-14 09:34||neil||Status||new => resolved|
|2014-04-14 09:34||neil||Fixed in Branch||=> 0.14 development branch|
|2014-04-14 09:34||neil||Resolution||open => done|
|2014-04-14 09:34||neil||Assigned To||=> neil|
|2014-04-14 09:39||neil||Note Edited: 0025831|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|