|
Viewing Issue Simple Details
[ Jump to Notes ]
[ Wiki ]
|
[ View Advanced ]
[ Issue History ]
[ Print ]
|
|
ID |
Category |
Severity |
Reproducibility |
Date Submitted |
Last Update |
|
0008369 |
[DCSS] Bug Report |
minor |
always |
2014-04-12 00:17 |
2014-04-14 09:35 |
|
|
Reporter |
blabber |
View Status |
public |
|
|
Assigned To |
neil |
|
Priority |
normal |
Resolution |
done |
|
|
Status |
resolved |
|
Product Branch |
0.14 ancient branch |
|
|
Summary |
0008369: Build fails with undefined reference to `debug_terp_dlua(CLua&)' if WIZARD is not defined (fix proposal included) |
|
Description |
Building without WIZARD defined fails with the following message:
main.cc:(.text+0x2468): undefined reference to `debug_terp_dlua(CLua&)'
As `debug_terp_dlua` only exists if WIZARD is defined this is no big surprise. I noticed this while porting the game to FreeBSD but the issue seems to be independent of the OS used.
A patch to master, fixing this issue for me, can be found in my github[1] or attached.
[1]: https://github.com/blabber/crawl/commit/944c04bef70238c427607bb57e6a44b23ebe20bb [^]
|
|
Additional Information |
|
| Tags |
No tags attached. |
|
|
Attached Files |
 0001-Fix-build-in-cases-where-WIZARD-is-not-defined.patch [^] (908 bytes) 2014-04-12 00:17 [Show Content] [Hide Content]From 944c04bef70238c427607bb57e6a44b23ebe20bb Mon Sep 17 00:00:00 2001
From: Tobias Rehbein <tobias.rehbein@web.de>
Date: Fri, 11 Apr 2014 23:43:33 +0200
Subject: [PATCH] Fix build in cases where WIZARD is not defined
As `debug_terp_dlua` only exists if WIZARD is defined it should only be called
if WIZARD is defined.
While here remove one superfluous `break;`
---
crawl-ref/source/main.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/crawl-ref/source/main.cc b/crawl-ref/source/main.cc
index ef62bf4..205f345 100644
--- a/crawl-ref/source/main.cc
+++ b/crawl-ref/source/main.cc
@@ -2156,9 +2156,11 @@ void process_command(command_type cmd)
canned_msg(MSG_OK);
break;
+#ifdef WIZARD
case CMD_LUA_CONSOLE:
- debug_terp_dlua(clua); break;
+ debug_terp_dlua(clua);
break;
+#endif
case CMD_NO_CMD:
default:
--
1.9.0
|
|
|
