0006841: Melded armour can't be enchanted - Dungeon Crawl Stone Soup Tracker

Notes
(0022013) mumra (developer) 2013-03-29 22:18	Perhaps scrolls that accept a target shouldn't allow you to use them on melded items at all.

(0022014) BlackSheep (reporter) 2013-03-30 00:40	This only happens when you read an unidentified scroll of enchant armour. If the scroll is identified, melded equipment is not a valid target. Scrolls of identify and recharging work just fine on melded equipment, so that's a bit of an inconsistency.

(0022015) mumra (developer) 2013-03-30 00:44	I've coded a change that prevents any scrolls being used on melded equipment and so actually removes the melded items from the menu on unidentified items. I'm waiting for some feedback before pushing it though; I think we should be consistent but should or shouldn't it be possible to use scrolls on melded things? I would say it shouldn't ever.

(0022023) Galefury (updater) 2013-03-30 11:01	On IRC it was brought up that melding is a tactical thing, so there's no need for it to affect the use of strategic scrolls. For example having to end transformation before trying to identify scrolls or enchanting something is not good. The main reason to not let scrolls affect melded equipment is realism, and we're talking about magical scrolls affecting magically melded magical items here.

(0022024) ldf (reporter) 2013-03-30 12:34	Actually I don't see what's wrong with enchanting melded armour. But if it is wrong, preventing scrolls being used on that equipment would be certainly better than it's now.

(0022042) mumra (developer) 2013-03-31 06:11	I've added a fix in trunk that prevents unidentified scrolls being used on melded gear (and also prevents using id and recharge scrolls on melded items). There has been some discussion and it's not clear what the best long-term solution is. There are still various inconsistencies with melded items and other scrolls (enchant/vorpalise/curse weapon scrolls won't work on melded weapons; curse armour/jewellery will work on melded armour; ash lets you remove curses on melded weapons but won't let you uncurse them etc.) It certainly might be that it's clearer and better if scrolls just universally work on melded equipment.

(0026090) elliptic (developer) 2014-05-08 08:20	Bumping this issue because the 0.14 changes to how read-IDing scrolls works made this situation much worse. Because it tells you that you read a scroll of enchant armour, you are simply losing out on +1 AC because you forgot to end your spider form before trying out a scroll. I don't see any good reason why scrolls shouldn't just work on melded equipment, personally. I actually assumed that we had already changed things to make them work until I ran into this myself just now...

(0026168) neil (administrator) 2014-05-13 23:46	Fixed in trunk (0.15-a0-808-g9f3982e). Now you should be able to enchant, recharge, curse, and uncurse melded items. It turns out it already worked for enchanting and branding weapons.

Issue History
Date Modified	Username	Field	Change
2013-03-29 21:14	ldf	New Issue
2013-03-29 22:18	mumra	Note Added: 0022013
2013-03-30 00:40	BlackSheep	Note Added: 0022014
2013-03-30 00:44	mumra	Note Added: 0022015
2013-03-30 11:01	Galefury	Note Added: 0022023
2013-03-30 12:34	ldf	Note Added: 0022024
2013-03-31 06:11	mumra	Note Added: 0022042
2013-03-31 07:57	mumra	Relationship added	related to 0005868
2014-05-08 08:20	elliptic	Note Added: 0026090
2014-05-13 23:46	neil	Note Added: 0026168
2014-05-13 23:46	neil	Status	new => resolved
2014-05-13 23:46	neil	Fixed in Branch	=> 0.15 development branch
2014-05-13 23:46	neil	Resolution	open => done
2014-05-13 23:46	neil	Assigned To	=> neil