Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006699 [DCSS] Patches minor N/A 2013-02-25 12:02 2013-03-06 13:44
Reporter Medar View Status public  
Assigned To edlothiol
Priority normal Resolution done  
Status closed   Product Branch 0.12 ancient branch
Summary 0006699: NumPad handling fixes for WebTiles
Description Patches 0001 and 0003 add numpad 5 and numpad insert to key_conversion.js, allowing these keys to be used without numlock on.

Patch 0004 changes numpad keys with numlock on to be handled as home, insert etc and not as numbers. Except for Firefox where keypress events for these numbers are sent and can't be told apart from regular number keys, as far as I know.
Additional Information
Tags No tags attached.
Attached Files ? file icon 0001-Support-numpad-5-in-WebTiles.patch [^] (1,294 bytes) 2013-02-25 12:02 [Show Content]
? file icon 0003-Support-numpad-insert-in-WebTiles.patch [^] (1,239 bytes) 2013-02-25 12:02 [Show Content]
? file icon 0004-Handle-numpad-as-numpad-on-WebTiles-even-with-numloc.patch [^] (2,250 bytes) 2013-02-25 12:02 [Show Content]

- Relationships

-  Notes
(0021272)
edlothiol (developer)
2013-03-05 21:04

Thanks, 1 and 3 are applied. I'm not sure 4 is a good idea; might people not want to use the numpad for numbers?
(0021288)
Medar (developer)
2013-03-06 13:19

Reasoning for that was just to be compatible with the local tiles version. Then again it does make Firefox and Chrome versions work differently. Plus, you are right, it might not be the smartest way to handle things to begin with.
(0021289)
edlothiol (developer)
2013-03-06 13:43

OK, if there's no real problem with the current behavior, I'll keep it this way for now.
(0021290)
Medar (developer)
2013-03-06 13:44

Sounds good to me.

- Issue History
Date Modified Username Field Change
2013-02-25 12:02 Medar New Issue
2013-02-25 12:02 Medar File Added: 0001-Support-numpad-5-in-WebTiles.patch
2013-02-25 12:02 Medar File Added: 0003-Support-numpad-insert-in-WebTiles.patch
2013-02-25 12:02 Medar File Added: 0004-Handle-numpad-as-numpad-on-WebTiles-even-with-numloc.patch
2013-03-05 21:04 edlothiol Note Added: 0021272
2013-03-06 13:19 Medar Note Added: 0021288
2013-03-06 13:43 edlothiol Note Added: 0021289
2013-03-06 13:43 edlothiol Status new => resolved
2013-03-06 13:43 edlothiol Fixed in Branch => 0.12 development branch
2013-03-06 13:43 edlothiol Resolution open => done
2013-03-06 13:43 edlothiol Assigned To => edlothiol
2013-03-06 13:44 Medar Note Added: 0021290
2013-03-06 13:44 Medar Status resolved => closed


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker