0006424: dump_order reproduces dump info instead of replacing dump info

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006424

[DCSS] Bug Report

minor

always

2012-11-30 22:37

2012-12-01 13:27

Reporter

ophanim

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Branch

0.12 ancient branch

Summary

0006424: dump_order reproduces dump info instead of replacing dump info

Description

dump_order is an rc option that allows users to specify how their log should be ordered when dumped. Currently it does not replace the default dump but appends to the end. It will also duplicate sections if they are included in the dump_order multiple times. See below for an example:

http://dobrazupa.org/morgue/ophanim/morgue-ophanim-20121130-212708.txt [^]

This was produced with "dump_order += messages,messages,messages,messages,messages,messages" in my rc.

Theoretically this is exploitable as a user could paste thousands of dump_order options to produce extremely large files, probably crashing servers or making them unplayable.

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0020593) chris (updater) 2012-11-30 22:49	Don't see a problem there, this is the intended behavior. If you want to replace the dump order, clear it before appending stuff.

(0020596) ophanim (reporter) 2012-12-01 07:21	Intended behavior is to produce a normal dump, then produce a second (or more) extra dump? That does not seem right.

(0020597) chris (updater) 2012-12-01 13:27	Well, you asked for exactly that by using += which appends things. As i said, if you do not want to get the default dump first, clear the option [dump_order=] and then append whatever you like.

Issue History
Date Modified	Username	Field	Change
2012-11-30 22:37	ophanim	New Issue
2012-11-30 22:49	chris	Note Added: 0020593
2012-12-01 07:21	ophanim	Note Added: 0020596
2012-12-01 13:27	chris	Note Added: 0020597

Mantis 1.1.8[^]