Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004907 [DCSS] Patches feature N/A 2011-11-16 17:24 2011-12-09 03:44
Reporter tukkek View Status public  
Assigned To KiloByte
Priority normal Resolution done  
Status resolved   Product Branch 0.10 ancient branch
Summary 0004907: Lua script engine extension
Description A few additions to Lua exposure. I take all are OK based on IRC discussion. Summarized:

item.is_useless -> is_useless_item(*item)
you.feel_safe -> i_feel_safe()
you.contaminated -> you.magic_contamination!=0

Note I have added some whitespace at 'you.deaths' - please remove this. I'm afraid of breaking the patch by removing it myself.
Additional Information
Tags No tags attached.
Attached Files ? file icon expand+lua+script+engine.patch [^] (2,054 bytes) 2011-11-16 17:24 [Show Content]
? file icon Lua+script+engine+extension%3A+you.caught%28%29.patch [^] (1,016 bytes) 2011-11-20 21:47 [Show Content]
? file icon Lua+script+engine+extension%3A+options.autopick_on.patch [^] (1,118 bytes) 2011-11-21 02:39 [Show Content]
? file icon Lua+script+engine+extension%3A+you.shrouded.patch [^] (1,027 bytes) 2011-12-01 18:09 [Show Content]
? file icon Lua+script+engine+extension%3A+you.swift.patch [^] (1,030 bytes) 2011-12-07 03:00 [Show Content]

- Relationships

-  Notes
(0015904)
tukkek (reporter)
2011-11-20 22:10
edited on: 2011-11-20 22:22

On second file: you.caught() -> you.caught()

(0015905)
KiloByte (manager)
2011-11-20 22:44

Both patches are in, thanks.
(0015913)
tukkek (reporter)
2011-11-21 02:39

KiloByte: thank you for accepting and applying.

I'm not sure if I should open a new issue, but I'm going for the easier and less noisy path of reopening this one.

On third file: options.autopick_on -> Options.autopickup_on>0

I also plan to make a Lua scripting guide on the code and development wiki soon. If this is enough to warrant a column in CREDITS.txt please do so as Alex Henry :)
(0016079)
tukkek (reporter)
2011-12-01 18:10
edited on: 2011-12-01 18:10

On fourth file: you.shrouded -> you.duration[DUR_SHROUD_OF_GOLUBRIA]

(0016134)
tukkek (reporter)
2011-12-07 03:00
edited on: 2011-12-07 03:00

On fifth file: you.swift -> you.duration[DUR_SWIFTNESS]

(0016174)
neil (administrator)
2011-12-09 03:44

Patches three through five are in (with tabs replaced with spaces to meet the DCSS coding style). Thanks.

- Issue History
Date Modified Username Field Change
2011-11-16 17:24 tukkek New Issue
2011-11-16 17:24 tukkek File Added: expand+lua+script+engine.patch
2011-11-20 21:47 tukkek File Added: Lua+script+engine+extension%3A+you.caught%28%29.patch
2011-11-20 22:10 tukkek Note Added: 0015904
2011-11-20 22:22 tukkek Note Edited: 0015904
2011-11-20 22:44 KiloByte Note Added: 0015905
2011-11-20 22:44 KiloByte Status new => resolved
2011-11-20 22:44 KiloByte Fixed in Branch => 0.10 development branch
2011-11-20 22:44 KiloByte Resolution open => done
2011-11-20 22:44 KiloByte Assigned To => KiloByte
2011-11-21 02:39 tukkek File Added: Lua+script+engine+extension%3A+options.autopick_on.patch
2011-11-21 02:39 tukkek Note Added: 0015913
2011-11-21 02:39 tukkek Status resolved => feedback
2011-11-21 02:39 tukkek Resolution done => reopened
2011-12-01 18:09 tukkek File Added: Lua+script+engine+extension%3A+you.shrouded.patch
2011-12-01 18:10 tukkek Note Added: 0016079
2011-12-01 18:10 tukkek Note Edited: 0016079
2011-12-07 03:00 tukkek Note Added: 0016134
2011-12-07 03:00 tukkek Note Edited: 0016134
2011-12-07 03:00 tukkek File Added: Lua+script+engine+extension%3A+you.swift.patch
2011-12-09 03:44 neil Note Added: 0016174
2011-12-09 03:44 neil Status feedback => resolved
2011-12-09 03:44 neil Resolution reopened => done


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker