Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004806 [DCSS] Bug Report minor have not tried 2011-10-25 01:33 2011-11-05 21:18
Reporter st View Status public  
Assigned To KiloByte
Priority normal Resolution done  
Status resolved   Product Branch 0.10 ancient branch
Summary 0004806: Ghouls no longer get sufficient health back from eating non-rotten chunks
Description Previously you could eat a yak and gain a fair amount of health back, now if you eat two yaks you are lucky to get anything back at all. This isn't really a balance issue - the point is ghouls are supposed to be able to kills things, eat them and move on without resting. Now you kill things, wait for the chunks to go rotten by which point you've already gained a bunch of HP back, then move on. (note: I'm not talking about rotten max HP in any way)
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0015628)
KiloByte (manager)
2011-10-31 16:25

Wasn't intentional. Fixed.
(0015712)
reid (reporter)
2011-11-04 18:22

commit c59df72af9d2877d3de01d51a8e8c301c5f2c17c
Author: Adam Borowski <kilobyte@angband.pl>
Date:   Mon Oct 31 16:19:41 2011 +0100

    Restore the healing ghouls get from clean chunks.
    
    Before the food changes, they got it in 4/5 cases (5/5 for "bad" chunks).
    By my mistake, it became 1/5 (and 5/5).
    
    I wonder about removing badness from the formula at all -- losing some theme
    but making playing more straightforward.

diff --git a/crawl-ref/source/food.cc b/crawl-ref/source/food.cc
index 8fd43a2..19f4907 100644
--- a/crawl-ref/source/food.cc
+++ b/crawl-ref/source/food.cc
@@ -1729,7 +1729,7 @@ static void _eat_chunk(corpse_effect_type chunk_effect, bool cannibal,
                 if (you.species == SP_GHOUL)
                 {
                     int hp_amt = 1 + random2(5) + random2(1 + you.experience_level);
-                    if (!x_chance_in_y(contam + 200, 1200))
+                    if (!x_chance_in_y(contam + 1000, 5000))
                         hp_amt = 0;
                     _heal_from_food(hp_amt, 0, !one_chance_in(4),
                                     x_chance_in_y(contam, 5000));


Now it's 1/5 chance to heal for noncontaminated, about 1/4 for contaminated. I don't think this is what you meant to do.
(0015727)
reid (reporter)
2011-11-05 21:18

ok, elliptic fixed this.

- Issue History
Date Modified Username Field Change
2011-10-25 01:33 st New Issue
2011-10-31 16:25 KiloByte Note Added: 0015628
2011-10-31 16:25 KiloByte Status new => resolved
2011-10-31 16:25 KiloByte Fixed in Branch => 0.10 development branch
2011-10-31 16:25 KiloByte Resolution open => done
2011-10-31 16:25 KiloByte Assigned To => KiloByte
2011-11-04 18:22 reid Note Added: 0015712
2011-11-05 21:18 reid Note Added: 0015727


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker