Main | My View | View Issues | Change Log | Wiki | Tavern | News
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004474 [DCSS] Bug Report minor always 2011-09-01 08:00 2011-09-01 15:18
Reporter AapoRantalainen View Status public  
Assigned To KiloByte
Priority normal Resolution done  
Status resolved   Product Branch 0.9 ancient branch
Summary 0004474: On ARM: char is unsigned as default
Description When compiling for ARM -target:

e.g.
tags.cc:1936: warning: comparison is always false due to limited range of data type
godpassive.cc:374: warning: comparison is always true due to limited range of data type


//Simple test
int main(void) {
 char i = -1;
 printf("%d\n", i);
 return 0;
}

On i386: -1
On ARM: 255

Compiling with 'gcc -fsigned-char' and ARM will print -1 also.
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0014436)
AapoRantalainen (reporter)
2011-09-01 08:22

 This is discussed (maybe fixed) earlier too:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=153931 [^]
(0014445)
KiloByte (manager)
2011-09-01 15:18

 -fsigned-char is unreliable, and causes problems with some system headers.

I had to replace all such uses of char with [u]int8_t (or int) before. Too bad, some new uses have crept it.

I've just plugged the new ones I noticed, but sadly, I'm not sure if I got them all.

This affects skill training and Ashenzari boosts, so this needs to be cherry-picked to 0.9 as well.

- Issue History
Date Modified Username Field Change
2011-09-01 08:00 AapoRantalainen New Issue
2011-09-01 08:22 AapoRantalainen Note Added: 0014436
2011-09-01 15:18 KiloByte Note Added: 0014445
2011-09-01 15:18 KiloByte Status new => resolved
2011-09-01 15:18 KiloByte Fixed in Branch => 0.10 development branch
2011-09-01 15:18 KiloByte Resolution open => done
2011-09-01 15:18 KiloByte Assigned To => KiloByte

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker