0002727: Error in calculating max_cloud_damage w/ MUT_PASSIVE_FREEZE

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002727

[DCSS] Bug Report

minor

always

2010-10-15 19:48

2010-10-15 19:59

Reporter

ubergeek

View Status

public

Assigned To

dolorous

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.7 ancient branch

Summary

0002727: Error in calculating max_cloud_damage w/ MUT_PASSIVE_FREEZE

Description

There is an error in the function max_cloud_damage that ignores CLOUD_FIRE/CLOUD_FOREST_FIRE when the MUT_PASSIVE_FREEZE is present. It would seem from the source that the only consequence of this is that the code which tries to avoid lethal miscasts relies on the value returned by max_cloud_damage (leading it to bypass such checks on CLOUD_FIRE when MUT_PASSIVE_FREEZE is present). Here is a patch which should fix the problem:

> diff -u cloud.cc cloud_fixed.cc
--- cloud.cc 2010-07-23 23:31:46.000000000 -0400
+++ cloud_fixed.cc 2010-10-15 13:38:43.000000000 -0400
@@ -680,10 +680,12 @@

         // Intentional fall-through
     case CLOUD_COLD:
- if (you.mutation[MUT_PASSIVE_FREEZE])
- return (0);
         if (cl_type == CLOUD_COLD)
+ {
+ if (you.mutation[MUT_PASSIVE_FREEZE])
+ return (0);
             resist = player_res_cold();
+ }

         if (resist <= 0)
         {

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0009015) dolorous (updater) 2010-10-15 19:59	Applied to trunk; thanks.

Issue History
Date Modified	Username	Field	Change
2010-10-15 19:48	ubergeek	New Issue
2010-10-15 19:59	dolorous	Note Added: 0009015
2010-10-15 19:59	dolorous	Status	new => resolved
2010-10-15 19:59	dolorous	Fixed in Branch	=> 0.8 development branch
2010-10-15 19:59	dolorous	Resolution	open => done
2010-10-15 19:59	dolorous	Assigned To	=> dolorous

Mantis 1.1.8[^]