Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001514 [DCSS] Bug Report minor always 2010-05-07 20:26 2010-05-16 20:51
Reporter MrMisterMonkey View Status public  
Assigned To dolorous
Priority normal Resolution done  
Status closed   Product Branch 0.7 ancient branch
Summary 0001514: Message errors when corroding unseen monsters' armour
Description Messages along the lines of "The acid corrodes it's orcish plate mail." for invisible monsters, possibly others for out-of-sight monsters (I didn't test for them); apparently the monster armour corrosion code forgot to check for visibility.

I think my patch fixes it, but it might need changing if I mistook you.can_see(monster) for something else.
Additional Information
Tags has patch
Attached Files ? file icon 0001-Fix-monster-corrosion-message-printing.patch [^] (1,127 bytes) 2010-05-07 20:26 [Show Content]

- Relationships

-  Notes
(0004680)
OG17 (reporter)
2010-05-07 23:11
edited on: 2010-05-07 23:11

This may go without saying, but you can't just tack on 's for unseen creatures; it's "its."

(0004681)
MrMisterMonkey (reporter)
2010-05-07 23:23

The patch fully removes the message for unseen monsters because you wouldn't be able to see the armour itself and know that it corroded; I'm not aware of any other cases in which it could trigger something like "it's".
(0004682)
dolorous (updater)
2010-05-08 00:25

Applied to trunk; thanks.

- Issue History
Date Modified Username Field Change
2010-05-07 20:26 MrMisterMonkey New Issue
2010-05-07 20:26 MrMisterMonkey File Added: 0001-Fix-monster-corrosion-message-printing.patch
2010-05-07 20:27 MrMisterMonkey Tag Attached: has patch
2010-05-07 23:11 OG17 Note Added: 0004680
2010-05-07 23:11 OG17 Note Edited: 0004680
2010-05-07 23:23 MrMisterMonkey Note Added: 0004681
2010-05-08 00:25 dolorous Note Added: 0004682
2010-05-08 00:26 dolorous Status new => resolved
2010-05-08 00:26 dolorous Fixed in Branch => 0.7 development branch
2010-05-08 00:26 dolorous Resolution open => done
2010-05-08 00:26 dolorous Assigned To => dolorous
2010-05-16 20:51 MrMisterMonkey Status resolved => closed


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker