Main | My View | View Issues | Change Log | Wiki | Tavern | News
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0010514 [DCSS] Bug Report minor have not tried 2016-06-18 15:02 2016-08-19 02:35
Reporter Yermak View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Branch 0.19 ancient branch
Summary 0010514: Item_slot not working properly
Description Item_slot doesn't work when identifying items by buying them in a shop.
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0030909)
Sandman25 (reporter)
2016-08-18 02:50
edited on: 2016-08-18 02:52

 I think the ticket can be closed with "Cannot reproduce". Item_slot works for me with latest master code (0.19-a0-1184-ged6e5f2)

p - an uncursed ring of poison resistance {rP+, !d}
Thank you for shopping at Hoc Erag's Jewellery Shop!

item_slot ^= ring of poison resistance:p

The item was shown as unknown to me in shop.
(0030912)
neil (administrator)
2016-08-18 08:25
edited on: 2016-08-18 08:44

 The problem apparently occurs when you buy-identify an item and it stacks with existing items: that seems to bypass the normal "reassign slot on identification" logic. Sandman25's test didn't reproduce the problem because it would never happen with rings or other unstackables.

*Edit*: It looks like reassign-on-ID only affects the precise item or stack identified, and not other identical items. So I suspect this also happens when you identify an item on the ground and have a matching item in your inventory: the latter is type-identified, but not reassigned.
(0030913)
Sandman25 (reporter)
2016-08-18 15:30

 I believe it is enough to add
auto_assign_item_slot(you.inv[inv_slot]) to
https://github.com/crawl/crawl/blob/master/crawl-ref/source/items.cc#L1907 [^]
to fix shop issue.
(0030914)
Sandman25 (reporter)
2016-08-19 02:35
edited on: 2016-08-19 02:35

 Yes, I tested it and the fix from previous post works indeed.


e - 7 scrolls of identify {!r} (gained 1)
q - 7 scrolls of identify {!r}; e - 4 scrolls labeled VIOKKUSEIMP {!r}
Thank you for shopping at Qeibexzo's Magic Scroll Shoppe!

I have
item_slot ^= scroll of identif:q

- Issue History
Date Modified Username Field Change
2016-06-18 15:02 Yermak New Issue
2016-08-18 02:50 Sandman25 Note Added: 0030909
2016-08-18 02:51 Sandman25 Note Edited: 0030909
2016-08-18 02:52 Sandman25 Note Edited: 0030909
2016-08-18 08:25 neil Note Added: 0030912
2016-08-18 08:43 neil Note Edited: 0030912
2016-08-18 08:44 neil Note Edited: 0030912
2016-08-18 08:44 neil Note Edited: 0030912
2016-08-18 15:30 Sandman25 Note Added: 0030913
2016-08-19 02:35 Sandman25 Note Added: 0030914
2016-08-19 02:35 Sandman25 Note Edited: 0030914

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker