0009142: Game crash on interacting with acidic walls in Slime

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0009142

[DCSS] Bug Report

crash

always

2014-11-05 22:10

2014-11-05 23:48

Reporter

Mandragora

View Status

public

Assigned To

wheals

Priority

normal

Resolution

done

Status

resolved

Product Branch

experimental branch

Summary

0009142: Game crash on interacting with acidic walls in Slime

Description

I am playing trunk webtiles on crawl.s-z.org with a character started a few days ago (Yred worshiper who experienced the joy of having all his items become holy wrath!)

Upon attempting to travel on, or tab-attacking onto (but not manually attacking onto) a monster on a tile next to an acidic wall in slime, the game crashes and restarts from the last staircase I entered - in this case, the M:1 entrance.

This same bug happened once to me on Crypt:3 earlier today, but I didn't take notice of the circumstances surrounding it and it did not happen again there.

Additional Information

Tags

No tags attached.

Attached Files

0001-Don-t-dereference-non-monster-evildoers.patch [^] (827 bytes) 2014-11-05 22:28 [Show Content] [Hide Content]

From bc1f8b04a9a4d99cf247867ee0205f994d115a3f Mon Sep 17 00:00:00 2001
From: Zannick <jokeserver@gmail.com>
Date: Wed, 5 Nov 2014 13:23:43 -0800
Subject: [PATCH] Don't dereference non-monster evildoers.

---
 crawl-ref/source/player.cc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/crawl-ref/source/player.cc b/crawl-ref/source/player.cc
index 47bc5a0..0e0aef1 100644
--- a/crawl-ref/source/player.cc
+++ b/crawl-ref/source/player.cc
@@ -7235,7 +7235,8 @@ void player::splash_with_acid(const actor* evildoer, int acid_strength,
         if (post_res_dam < dam)
             canned_msg(MSG_YOU_RESIST);
 
-        ouch(post_res_dam, evildoer->mindex(), KILLED_BY_ACID);
+        ouch(post_res_dam, evildoer ? evildoer->mindex() : NON_MONSTER,
+             KILLED_BY_ACID);
     }
 }
 
-- 
1.7.2.5

Relationships

Notes
(0027667) Zannick (reporter) 2014-11-05 22:32	This code got recently rearranged and one of the null checks got dropped. Attached a 1ish-line patch to fix.

(0027669) wheals (administrator) 2014-11-05 23:48	Thank you Zannick! Patch applied in 0.16-a0-1916-gff07b5f.

Issue History
Date Modified	Username	Field	Change
2014-11-05 22:10	Mandragora	New Issue
2014-11-05 22:28	Zannick	File Added: 0001-Don-t-dereference-non-monster-evildoers.patch
2014-11-05 22:32	Zannick	Note Added: 0027667
2014-11-05 23:48	wheals	Note Added: 0027669
2014-11-05 23:48	wheals	Status	new => resolved
2014-11-05 23:48	wheals	Fixed in Branch	=> 0.16 development branch
2014-11-05 23:48	wheals	Resolution	open => done
2014-11-05 23:48	wheals	Assigned To	=> wheals

Mantis 1.1.8[^]