0007984: Report of attack speed in @ does not take into account shield penalties

Notes
(0024989) wheals (administrator) 2014-01-14 14:11	This doesn't seem to be the case. Rather, the problem is that shields cause an unpredictable element of slowing, rather than a specific reduction in attack delay. This means that what you'll see in @ will be the expected/"average" attack delay, while your actual attack delay will sometimes be as low as without a shield, or much higher than it.

(0024992) amic (reporter) 2014-01-15 03:28 edited on: 2014-01-15 03:53	Apparently it does take shields into account (I noticed it changed when I increased my shield size), but it doesn't seem to do it correctly. Wielding a weapon at min delay .7 and a large shield with 11.2 Shields skill (as a normal sized character), it says my attack speed is "quite fast", which according to the learndb should mean average delay of less than .75. But the shields formulas and my own testing bashing plants gives an average delay that is definitely over .8.

(0024993) amic (reporter) 2014-01-15 04:25	Some further data from wizmode testing: with a dagger at mindelay, a large shield, and 10.5 Shields skill, my average attack delay is reported as 50%, but when I actually hit things, I frequently get delays of .6 or .7. At 10.4 Shields skill, my average attack delay is reported as 60%. It looks like something is getting inappropriately rounded at some point in the average delay calculation.

(0024994) ion_frigate (reporter) 2014-01-15 04:56 edited on: 2014-01-15 04:58	Given the fact that the actual weapon delay is easily visible by hitting a monster (or if you have a shield, hitting a monster several times), why not just remove the cumbersome adjectives for speed that even experienced players have to look up sometimes, and show the actual average weapon delay? Or at the very least, give the number and then the adjective, like so: "Your attack delay is 0.7 (quite fast)."

(0024995) wheals (administrator) 2014-01-15 04:59	Well that wouldn't help in this case, since there seems to be something wrong with the calculation of average weapon delay (unless you're suggesting an fsim every time the player presses @). I agree with that idea, but since the game converts directly from the delay to a word, it seems there's a problem with the actual delay calculation.

(0028949) golthoon (reporter) 2015-04-21 19:35 edited on: 2015-04-21 19:39	Confirming that this oddity is still present in 0.16.1; the issue is that the game prints the line "(and cannot be increased with skill)" but this only acknowledges _weapon_ skill. A player with sufficient weapon skill to reach minimum delay can still have their attacks slowed by wearing a shield while insufficiently skilled with them, in which case the line above is misleading: In fact, the player's attack speed _could_ be increased with skill - the Shields skill.

(0028995) golthoon (reporter) 2015-05-01 18:50	Does the fix for 0009687 also fix ^?

(0029768) wheals (administrator) 2015-11-10 17:49	Fixed in https://github.com/crawl/crawl/commit/2733cf4fda70. [^]

Issue History
Date Modified	Username	Field	Change
2014-01-14 12:44	amic	New Issue
2014-01-14 14:11	wheals	Note Added: 0024989
2014-01-15 03:28	amic	Note Added: 0024992
2014-01-15 03:53	amic	Note Edited: 0024992
2014-01-15 04:25	amic	Note Added: 0024993
2014-01-15 04:56	ion_frigate	Note Added: 0024994
2014-01-15 04:57	ion_frigate	Note Edited: 0024994
2014-01-15 04:58	ion_frigate	Note Edited: 0024994
2014-01-15 04:59	wheals	Note Added: 0024995
2015-04-21 19:35	golthoon	Note Added: 0028949
2015-04-21 19:39	golthoon	Note Edited: 0028949
2015-05-01 18:50	golthoon	Note Added: 0028995
2015-11-10 17:49	wheals	Note Added: 0029768
2015-11-10 17:49	wheals	Status	new => resolved
2015-11-10 17:49	wheals	Fixed in Branch	=> 0.18 development branch
2015-11-10 17:49	wheals	Resolution	open => done
2015-11-10 17:49	wheals	Assigned To	=> wheals

Relationships