0006936: Hit twice by distortion, the 2 disto effects happened after the 2nd hit

Notes
(0022352) LexAckson (reporter) 2013-04-19 23:09	but if we change this pan lord distortion monks won't be so frightening...

(0022373) sgrunt (administrator) 2013-04-22 02:39	First, let me explain why this was happening, and then what the fix was. Up until just now, monsters would take turns one at a time, using up all of their available turns immediately, and then firing final effects (including distortion hits) just before handing off control to the next monster. As what may be the first step towards a greater overhaul of the monster acting system, as of 0.13-a0-419-g27b33f2, monsters now only take one turn at a time (firing final effects after their turn) before checking to see who gets the next turn. Thus, faster monsters might get a turn before mid-speed monsters and a turn after, as opposed to the fast monster getting two turns before the mid-speed monster gets one (or perhaps the mid-speed monster getting a turn before the fast monster getting two, depending on where they were in the monster list!). Anyway, this issue has gone away with that change.

(0022446) rchandra (reporter) 2013-04-26 00:11	Still happening. Sonja hits you with an uncursed short sword of distortion. x2 Your surroundings suddenly seem different. You are cast into the Abyss! http://dobrazupa.org/saves/rchandra-crawl-git-1bf6f2f353-130425-2211.tar.bz2 [^]

(0022448) DracoOmega (developer) 2013-04-26 09:39	Sonja actually has multiple attacks a round, so merely changing how monster TURNS are scheduled would not make each attack into a separate event here. But I sort of assume there are other issues with final effects being fired after each attack instead of an attack round, since wasn't that the problem they were introduced to solve in the first place?

(0022449) KiloByte (manager) 2013-04-26 12:18	Without final attacks, we would have to re-evaluate validity of everything[1] after nearly every line of code. That's the problem they're supposed to fix. There's nothing wrong with firing them after each attack, as long as you can handle things becoming invalid. [1]. Both attacker and defender still being alive, being within weapon range, not incapacitated, on the same level, etc.

(0024054) sgrunt (administrator) 2013-09-19 05:19	This should finally have gone away with 0.13-a0-3104-gb5885e9, which fires fineffs after individual monster attacks.

Issue History
Date Modified	Username	Field	Change
2013-04-19 22:49	Wahaha	New Issue
2013-04-19 23:09	LexAckson	Note Added: 0022352
2013-04-22 02:39	sgrunt	Note Added: 0022373
2013-04-22 02:39	sgrunt	Assigned To	=> sgrunt
2013-04-22 02:39	sgrunt	Status	new => resolved
2013-04-22 02:39	sgrunt	Resolution	open => done
2013-04-22 02:39	sgrunt	Fixed in Branch	=> 0.13 development branch
2013-04-26 00:11	rchandra	Note Added: 0022446
2013-04-26 00:20	sgrunt	Status	resolved => new
2013-04-26 00:20	sgrunt	Resolution	done => reopened
2013-04-26 00:21	sgrunt	Status	new => confirmed
2013-04-26 09:39	DracoOmega	Note Added: 0022448
2013-04-26 12:18	KiloByte	Note Added: 0022449
2013-09-19 05:19	sgrunt	Note Added: 0024054
2013-09-19 05:19	sgrunt	Status	confirmed => resolved
2013-09-19 05:19	sgrunt	Resolution	reopened => done

Relationships