Anonymous | Login | 2024-04-27 00:59 CEST |
Main | My View | View Issues | Change Log | Wiki | Tavern | News |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||||||
ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||||||
0002296 | [DCSS] FR: Interface Improvements | minor | N/A | 2010-08-17 09:14 | 2014-11-05 16:20 | ||||||||
Reporter | OG17 | View Status | public | ||||||||||
Assigned To | wheals | ||||||||||||
Priority | normal | Resolution | done | ||||||||||
Status | resolved | Product Branch | 0.8 ancient branch | ||||||||||
Summary | 0002296: Allow small_more regardless of clear_messages settings | ||||||||||||
Description | "Small_more = true" changes the --more-- message from a line-wasting prompt to a tidy little "+" message prefix. However, this only works with the perversely scrolling "clear_messages = false" - it has no effect when messages are instead rightfully set to be cleared, even though its functionality would be identical. This seems to be intentional, as the guide describes how it doesn't work - why not? This option should be allowed for both settings, as it's equally desirable under either. | ||||||||||||
Additional Information | |||||||||||||
Tags | Jiyva, octopode, tentacle, tentacles | ||||||||||||
Attached Files | |||||||||||||
|
Notes | |
(0024188) chris (updater) 2013-10-12 21:02 |
Because clear_messages does not leave the first message column empty for `_` abominations, small_more will overwrite the first letter of the last message line with its `+` instead. I think that behavior is still to be vastly preferred over just ignoring the setting - what is gained by doing so, after all? Players disliking the new overwrite-first-letter mechanic can still go back and unset small_more and nothing changed for them. The patch itself trivial (unless you want to look into padding the last message line instead): From 330f36ccdf469e358079a3afb9327ef62b6253bd Mon Sep 17 00:00:00 2001 From: Chris Oelmueller <chris.oelmueller@gmail.com> Date: Sat, 12 Oct 2013 21:00:24 +0200 Subject: Allow small_more to work with clear_messages Previously, combining both options caused the small_more setting to be disabled regardless of player settings. Fixes 0002296 --- crawl-ref/docs/options_guide.txt | 5 +++-- crawl-ref/source/message.cc | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/crawl-ref/docs/options_guide.txt b/crawl-ref/docs/options_guide.txt index ddd8310..c15c01f 100644 --- a/crawl-ref/docs/options_guide.txt +++ b/crawl-ref/docs/options_guide.txt @@ -1315,8 +1315,9 @@ show_more = true small_more = false With small_more = false (default), the --more-- prompt is on a separate line at the bottom of the message window. With - small_more = true, it is just the bottom left character if - clear_messages is not set. + small_more = true, it is just the bottom left character. + Note: This will overwrite the first letter of the last message + line if clear_messages is set. show_inventory_weights = false When this is set to true, inventory listings will mention the diff --git a/crawl-ref/source/message.cc b/crawl-ref/source/message.cc index 735611e..d760594 100644 --- a/crawl-ref/source/message.cc +++ b/crawl-ref/source/message.cc @@ -435,7 +435,7 @@ public: bool first_col_more() const { - return (use_first_col() && Options.small_more); + return Options.small_more; } bool use_first_col() const -- 1.8.4 |
(0027653) wheals (administrator) 2014-11-05 16:20 |
0.16-a0-1904-gde8d0ee |
Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group |