Anonymous | Login | 2024-04-26 23:48 CEST |
Main | My View | View Issues | Change Log | Wiki | Tavern | News |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||||||
ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||||||
0012170 | [DCSS] Bug Report | trivial | have not tried | 2020-01-04 17:08 | 2020-04-20 17:37 | ||||||||
Reporter | hittemvvvhard | View Status | public | ||||||||||
Assigned To | aidanholm | ||||||||||||
Priority | normal | Resolution | done | ||||||||||
Status | resolved | Product Branch | experimental branch | ||||||||||
Summary | 0012170: net trap revealed by magic mapping has wrong tile | ||||||||||||
Description | see attached image | ||||||||||||
Additional Information | |||||||||||||
Tags | No tags attached. | ||||||||||||
Attached Files | SZJSXBj.png [^] (146,049 bytes) 2020-01-04 17:08 | ||||||||||||
|
Notes | |
(0033647) aidanholm (developer) 2020-01-06 14:08 |
trap_category() maps the net trap_type -> mechanical dungeon_feature_type, since for some reason there are fewer feature types than trap types. Then tileidx_out_of_los() chooses the bg based on cell.feat() alone for magic-mapped cells. |
(0033656) hittemvvvhard (reporter) 2020-01-11 17:58 |
same issue for pressure plates looking like this |
(0033716) Goratrix (reporter) 2020-03-20 15:21 edited on: 2020-03-20 15:25 |
Just thinking, could this be resolved relatively easily (without reworking the types, etc...) by creating a new 'generic mechanical trap' tile image and then referencing it here? https://github.com/crawl/crawl/blob/master/crawl-ref/source/tilepick.cc#L217 [^] Or would that break tile display in some other situations? The existing pressure plate tile (or some modification of it, adding a question mark or something) could work well. |
(0033717) Goratrix (reporter) 2020-03-20 19:14 |
Proposed fix sumbitted as PR 1323. |
(0033774) aidanholm (developer) 2020-04-16 19:38 |
(Permanent) teleport traps have the same problem. |
(0033777) aidanholm (developer) 2020-04-20 17:37 |
0.25-a0-825-g30a70f5 |
Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group |