Viewing Issue Advanced Details Jump to Notes ] Wiki ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007127 [DCSS] Patches minor always 2013-06-01 04:37 2013-06-02 04:13
Reporter qoala View Status public  
Assigned To brendan
Priority normal Resolution done Local or Remote Both
Status resolved   Operating System All
Projection none   Console or Tiles Both
ETA none Fixed in Branch 0.13 ancient branch Product Branch 0.13 ancient branch
  Product Version cde634
Summary 0007127: Missing parentheses in gargoyle petrification-stat-loss
Description Players have a gargoyle_damage_reduction field which seems intended to store the largest single damage reduction a gargoyle received from the petrification bonus during a self-petrification cycle.

As it was, the ouch.cc code which updated this value used (dam + 1 / 2), which as written evaluates simply to (dam). I've added in the likely missing parentheses which evaluates this to the amount of damage reduced by the later (dam /= 2;).

This will approximately halve the probability of stat loss from self-petrification, as the probability is the stored value over max hp. Similar reduction in exhaustion following petrification.
Steps To Reproduce
Additional Information
Tags No tags attached.
Attached Files ? file icon gr_petr_stat_loss_paren.patch [^] (1,106 bytes) 2013-06-01 04:37 [Show Content]

- Relationships

-  Notes
(0023011)
brendan (developer)
2013-06-02 04:13

Committed. Thanks!

- Issue History
Date Modified Username Field Change
2013-06-01 04:37 qoala New Issue
2013-06-01 04:37 qoala File Added: gr_petr_stat_loss_paren.patch
2013-06-02 04:13 brendan Note Added: 0023011
2013-06-02 04:13 brendan Status new => resolved
2013-06-02 04:13 brendan Fixed in Branch => 0.13 development branch
2013-06-02 04:13 brendan Resolution open => done
2013-06-02 04:13 brendan Assigned To => brendan


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker