0001555: make command repetition work using delays - Dungeon Crawl Stone Soup Tracker

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001555

[DCSS] Source Cleanup

minor

have not tried

2010-05-15 17:27

2015-04-14 18:31

Reporter

rob

View Status

public

Assigned To

Kate

Priority

normal

Resolution

done

Local or Remote

Local

Status

closed

Operating System

Other

Projection

none

Console or Tiles

Both

ETA

none

Fixed in Branch

0.16 ancient branch

Product Branch

0.7 ancient branch

Product Version

Summary

0001555: make command repetition work using delays

Description

I'm not really sure this will work out, but it would hopefully make things cleaner.

It should be more or less similar to the implementation of Lua macros, with DELAY_MACRO and DELAY_MACRO_PROCESS_KEYS. (DELAY_REPEAT_PROCESS_KEYS could probably be merged with DELAY_MACRO_PROCESS_KEYS). DELAY_REPEAT would copy the repeat keys into the key buffer, decrement the repeat counter, and push a "process keys" delay.

With this, maybe some instances of crawl_state.cancel_cmd_repeat could be replaced with appropriate calls to interrupt_activity.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0028861) Kate (developer) 2015-04-14 18:31	Closing some old FRs, these might still be desirable but they don't need to have Mantis issues for them.

Issue History
Date Modified	Username	Field	Change
2010-05-15 17:27	rob	New Issue
2015-04-14 18:31	Kate	Note Added: 0028861
2015-04-14 18:31	Kate	Status	new => resolved
2015-04-14 18:31	Kate	Fixed in Branch	=> 0.16 pre-release branch
2015-04-14 18:31	Kate	Resolution	open => done
2015-04-14 18:31	Kate	Assigned To	=> Kate
2015-04-14 18:31	Kate	Status	resolved => closed

Mantis 1.1.8[^]