Fix auto-pickup multiple Misc

[le_nerd]

So previously the main problem with auto-pickup Misc was that you picked up the trash simple decks. Now that decks are history, and most Misc items are stackable its great to have misc on auto-pickup again! But it still picks up multiple elemental evokers, discs of storm, and CboE.

Would be awesome to fix this.

[Sar]

it would also be great to have decks on auto-pickup as a Nemelex follower without having to put all the misc items on autopickup

[Rast]

How is CBoE still in Crawl, anyway?

[ydeve]

Does anyone even use it now that "clarity is gone?

[Sar]

Ash followers? People with lots of curing? Weeaboos?

[crate]

cboe is still very good

of course, that might be why one questions its continued existence

[Rast]

It's good in the same way lantern of shadows was good, only more niche.

[Shtopit]

Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

[genericpseudonym]

it would also be great to have decks on auto-pickup as a Nemelex follower without having to put all the misc items on autopickup

I just autopickup everything with {god gift}

And hey, non-gift decks have already been removed!

Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

press \

[Sar]

I just autopickup everything with {god gift}

yes but then I would have to edit rc instead of pressing / and choosing an option like a casual I am

actually that menu could really use a "god gift" option

[CanOfWorms]

Ash followers? People with lots of curing? Weeaboos?

zinners

[rchandra]

I just autopickup everything with {god gift}

yes but then I would have to edit rc instead of pressing / and choosing an option like a casual I am

And wondering why you keep running everywhere!

(the command is \, for future readers)

[xbon]

Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

this auto pickup does what you want...

  Code:

# autopickup by Medar, tweaked by rchandra
{
local function armour_plus(it)
  local plus = string.gsub(it.name(), "+", "", 1)
  return tonumber(string.gsub(plus, "[^-%d]", ""))
end

local function autopickup(it, name)
    if it.is_useless then
        return false
    end
    if it.artefact then
        return true
    end
    local class = it.class(true)
    if class == "armour" then
        local good_slots = {cloak="Cloak", helmet="Helmet",
                            gloves="Gloves", boots="Boots",
                            shield="Shield"}
        st, _ = it.subtype()
        weap = items.equipped_at("Weapon")
        if st == "shield" and weap ~=nil and weap.hands == 2 then return false end

        if good_slots[st] ~= nil then
            if it.branded then return true end
   
            local cur = items.equipped_at(good_slots[st])
            if cur == nil then return true end
   
            if cur.branded or cur.artefact then return false end
            if armour_plus(it) ~= nil then
                if armour_plus(it) > armour_plus(cur) then return true end
            else
                if armour_plus(cur) < 0 then return true end
            end
        elseif st == "body" then
            local cur = items.equipped_at("armour")
            if cur == nil then return false end
            if cur.name("qual") ~= it.name("qual") then return false end
   
            if it.branded then return true end
   
            if cur.branded or cur.artefact then return false end
            if armour_plus(it) ~= nil then
                if armour_plus(it) > armour_plus(cur) then return true end
            else
                if armour_plus(cur) < 0 then return true end
            end
        end
    end

    return
end

add_autopickup_func(autopickup)
}

once you pick up one of a certain type of ring <magic resistance, poison resistance, etc> it takes the rest off auto pickup (it'll also try and pick up any valid item slot that you don't have equipped, and if yours isn't branded it'll look for a branded version, etc.) kudos to rchandra and Medar for making it.

just put it in your init.txt (or rcfile if playing online)

as for not picking up multiple misc, why wouldn't you want to? Two phials of flood is better than one,since you can use the other when one is off cooldown, etc, maybe it comes down to personal preference but I love decks (since you can just eVoke them like wands now) and multiple miscs.

[genericpseudonym]

as for not picking up multiple misc, why wouldn't you want to? Two phials of flood is better than one,since you can use the other when one is off cooldown, etc, maybe it comes down to personal preference but I love decks (since you can just eVoke them like wands now) and multiple miscs.

This hasn't been the case since .17 or earlier. Nowadays all phials share the same cooldown period.

It's still useful to carry multiple decks, bobs, sacks, or mirrors. Just not the elemental evokers.

[Sar]

It's also often useful to have two rings of MR...

[xbon]

as for not picking up multiple misc, why wouldn't you want to? Two phials of flood is better than one,since you can use the other when one is off cooldown, etc, maybe it comes down to personal preference but I love decks (since you can just eVoke them like wands now) and multiple miscs.

This hasn't been the case since .17 or earlier. Nowadays all phials share the same cooldown period.

It's still useful to carry multiple decks, bobs, sacks, or mirrors. Just not the elemental evokers.

ahhhh, did not know this. haven't found multiples in a while (or rather haven't needed to evoke a second one in the time it would cooldown)

[rchandra]

Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

this auto pickup does what you want...


once you pick up one of a certain type of ring <magic resistance, poison resistance, etc> it takes the rest off auto pickup (it'll also try and pick up any valid item slot that you don't have equipped, and if yours isn't branded it'll look for a branded version, etc.) kudos to rchandra and Medar for making it.

Sadly that one just works on armours, the ring problem is more difficult especially as Octopodes, Ru, and the macabre necklace all exist. You might be better off just setting all known rings to not pick-up, then manually getting the duplicates that you want. I just use \ each time, so far.

[crate]

If you set autopickup exceptions to not pick up "ring of" then you won't autopickup type-identified rings. You can then either set further exceptions for the rings you do want to pick up (ring of slaying, protection, etc.) or just pick them up manually.

[duvessa]

If you set autopickup exceptions to not pick up "ring of" then you won't autopickup type-identified rings. You can then either set further exceptions for the rings you do want to pick up (ring of slaying, protection, etc.) or just pick them up manually.

this is actually how the default autopickup works for amulets; the problem is, monsters can wear rings and amulets and identify them and then autopickup misses them. monster jewellery is such a good addition to the game!!

[xbon]

Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

this auto pickup does what you want...


once you pick up one of a certain type of ring <magic resistance, poison resistance, etc> it takes the rest off auto pickup (it'll also try and pick up any valid item slot that you don't have equipped, and if yours isn't branded it'll look for a branded version, etc.) kudos to rchandra and Medar for making it.

Sadly that one just works on armours, the ring problem is more difficult especially as Octopodes, Ru, and the macabre necklace all exist. You might be better off just setting all known rings to not pick-up, then manually getting the duplicates that you want. I just use \ each time, so far.

you sure? because once I id a ring and have it equipped it doesn't pick up the other ones of that exact type, don't have anything else that would modify my autopickups, no current exceptions set.

[johlstei]

Why do multiples of elemental evokers spawn again?

[genericpseudonym]

Why do multiples of elemental evokers spawn again?

The game spawns plenty of things that the player doesn't care about. You can get duplicate amulets, naga bardings on non-nagas, scrolls of blinking on formicids...

[Sprucery]

Why do multiples of elemental evokers spawn again?

The game spawns plenty of things that the player doesn't care about. You can get duplicate amulets, naga bardings on non-nagas, scrolls of blinking on formicids...

Also, if you are in a portal vault and are out of inventory space, you can drop an elemental evoker there if you know that you have another one waiting for you in the dungeon.

This has never happened to me, but it could be possible.