Fix auto-pickup multiple Misc


Although the central place for design discussion is ##crawl-dev on freenode, some may find it helpful to discuss requests and suggestions here first.

Tomb Titivator

Posts: 808

Joined: Sunday, 23rd June 2013, 15:20

Post Saturday, 18th June 2016, 09:06

Fix auto-pickup multiple Misc

So previously the main problem with auto-pickup Misc was that you picked up the trash simple decks. Now that decks are history, and most Misc items are stackable its great to have misc on auto-pickup again! But it still picks up multiple elemental evokers, discs of storm, and CboE.

Would be awesome to fix this.

Sar

User avatar

Ziggurat Zagger

Posts: 6418

Joined: Friday, 6th July 2012, 12:48

Post Saturday, 18th June 2016, 09:36

Re: Fix auto-pickup multiple Misc

it would also be great to have decks on auto-pickup as a Nemelex follower without having to put all the misc items on autopickup

For this message the author Sar has received thanks:
ydeve

Tartarus Sorceror

Posts: 1739

Joined: Tuesday, 13th March 2012, 02:48

Post Saturday, 18th June 2016, 14:05

Re: Fix auto-pickup multiple Misc

How is CBoE still in Crawl, anyway?

For this message the author Rast has received thanks: 3
duvessa, Sandman25, ydeve

Tomb Titivator

Posts: 885

Joined: Sunday, 28th June 2015, 14:44

Post Saturday, 18th June 2016, 17:19

Re: Fix auto-pickup multiple Misc

Does anyone even use it now that "clarity is gone?

Sar

User avatar

Ziggurat Zagger

Posts: 6418

Joined: Friday, 6th July 2012, 12:48

Post Saturday, 18th June 2016, 18:18

Re: Fix auto-pickup multiple Misc

Ash followers? People with lots of curing? Weeaboos?

Ziggurat Zagger

Posts: 4055

Joined: Tuesday, 10th January 2012, 19:49

Post Saturday, 18th June 2016, 18:29

Re: Fix auto-pickup multiple Misc

cboe is still very good

of course, that might be why one questions its continued existence

Tartarus Sorceror

Posts: 1739

Joined: Tuesday, 13th March 2012, 02:48

Post Saturday, 18th June 2016, 19:54

Re: Fix auto-pickup multiple Misc

It's good in the same way lantern of shadows was good, only more niche.
User avatar

Tartarus Sorceror

Posts: 1698

Joined: Saturday, 18th June 2016, 13:57

Post Saturday, 18th June 2016, 20:58

Re: Fix auto-pickup multiple Misc

Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?
I Feel the Need--the Need for Beer
Spoiler: show
3DSBeTr 15DSFiRu 3DSMoNe 3FoHuGo 3TrArOk 3HOFEVe 3MfGlOk 4GrEEVe 3BaIEChei 3HuMoOka 3MiWnQaz 3VSFiAsh 3DrTmMakh 3DSCKXom 3OgMoOka 3NaFiOka 3FoFiOka 3MuFEVeh 3CeHuOka 3TrMoTSO 3DEFESif 3DSMoOka 3DSFiOka

Slime Squisher

Posts: 395

Joined: Monday, 28th April 2014, 19:50

Post Saturday, 18th June 2016, 21:12

Re: Fix auto-pickup multiple Misc

Sar wrote:it would also be great to have decks on auto-pickup as a Nemelex follower without having to put all the misc items on autopickup

I just autopickup everything with {god gift}

And hey, non-gift decks have already been removed!

Shtopit wrote:Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

press \

Sar

User avatar

Ziggurat Zagger

Posts: 6418

Joined: Friday, 6th July 2012, 12:48

Post Saturday, 18th June 2016, 22:40

Re: Fix auto-pickup multiple Misc

genericpseudonym wrote:I just autopickup everything with {god gift}

yes but then I would have to edit rc instead of pressing / and choosing an option like a casual I am

actually that menu could really use a "god gift" option

For this message the author Sar has received thanks:
ydeve

Dungeon Master

Posts: 625

Joined: Thursday, 23rd October 2014, 03:08

Post Saturday, 18th June 2016, 22:48

Re: Fix auto-pickup multiple Misc

Sar wrote:Ash followers? People with lots of curing? Weeaboos?

zinners

For this message the author CanOfWorms has received thanks: 2
Sar, ydeve
User avatar

Vestibule Violator

Posts: 1509

Joined: Wednesday, 21st September 2011, 01:10

Location: St. John's, NL, Canada

Post Sunday, 19th June 2016, 03:32

Re: Fix auto-pickup multiple Misc

Sar wrote:
genericpseudonym wrote:I just autopickup everything with {god gift}

yes but then I would have to edit rc instead of pressing / and choosing an option like a casual I am


And wondering why you keep running everywhere!

(the command is \, for future readers)
Won all race/bg, unwon (online): Nem* Hep Uka
Favourites: 15-rune Trog, OgNe/OgIE/OgSu (usually Ash), Ds, Ru, SpEn, Ce of Chei, Qaz

For this message the author rchandra has received thanks:
Sar

Lair Larrikin

Posts: 29

Joined: Thursday, 13th March 2014, 16:44

Post Wednesday, 22nd June 2016, 05:43

Re: Fix auto-pickup multiple Misc

Shtopit wrote:Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

this auto pickup does what you want...

  Code:
# autopickup by Medar, tweaked by rchandra
{
local function armour_plus(it)
  local plus = string.gsub(it.name(), "+", "", 1)
  return tonumber(string.gsub(plus, "[^-%d]", ""))
end

local function autopickup(it, name)
    if it.is_useless then
        return false
    end
    if it.artefact then
        return true
    end
    local class = it.class(true)
    if class == "armour" then
        local good_slots = {cloak="Cloak", helmet="Helmet",
                            gloves="Gloves", boots="Boots",
                            shield="Shield"}
        st, _ = it.subtype()
        weap = items.equipped_at("Weapon")
        if st == "shield" and weap ~=nil and weap.hands == 2 then return false end

        if good_slots[st] ~= nil then
            if it.branded then return true end
   
            local cur = items.equipped_at(good_slots[st])
            if cur == nil then return true end
   
            if cur.branded or cur.artefact then return false end
            if armour_plus(it) ~= nil then
                if armour_plus(it) > armour_plus(cur) then return true end
            else
                if armour_plus(cur) < 0 then return true end
            end
        elseif st == "body" then
            local cur = items.equipped_at("armour")
            if cur == nil then return false end
            if cur.name("qual") ~= it.name("qual") then return false end
   
            if it.branded then return true end
   
            if cur.branded or cur.artefact then return false end
            if armour_plus(it) ~= nil then
                if armour_plus(it) > armour_plus(cur) then return true end
            else
                if armour_plus(cur) < 0 then return true end
            end
        end
    end

    return
end

add_autopickup_func(autopickup)
}


once you pick up one of a certain type of ring <magic resistance, poison resistance, etc> it takes the rest off auto pickup (it'll also try and pick up any valid item slot that you don't have equipped, and if yours isn't branded it'll look for a branded version, etc.) kudos to rchandra and Medar for making it.

just put it in your init.txt (or rcfile if playing online)

as for not picking up multiple misc, why wouldn't you want to? Two phials of flood is better than one,since you can use the other when one is off cooldown, etc, maybe it comes down to personal preference but I love decks (since you can just eVoke them like wands now) and multiple miscs.

Slime Squisher

Posts: 395

Joined: Monday, 28th April 2014, 19:50

Post Wednesday, 22nd June 2016, 06:56

Re: Fix auto-pickup multiple Misc

xbon wrote:as for not picking up multiple misc, why wouldn't you want to? Two phials of flood is better than one,since you can use the other when one is off cooldown, etc, maybe it comes down to personal preference but I love decks (since you can just eVoke them like wands now) and multiple miscs.


This hasn't been the case since .17 or earlier. Nowadays all phials share the same cooldown period.

It's still useful to carry multiple decks, bobs, sacks, or mirrors. Just not the elemental evokers.

For this message the author genericpseudonym has received thanks:
xbon

Sar

User avatar

Ziggurat Zagger

Posts: 6418

Joined: Friday, 6th July 2012, 12:48

Post Wednesday, 22nd June 2016, 07:38

Re: Fix auto-pickup multiple Misc

It's also often useful to have two rings of MR...

Lair Larrikin

Posts: 29

Joined: Thursday, 13th March 2014, 16:44

Post Wednesday, 22nd June 2016, 09:20

Re: Fix auto-pickup multiple Misc

genericpseudonym wrote:
xbon wrote:as for not picking up multiple misc, why wouldn't you want to? Two phials of flood is better than one,since you can use the other when one is off cooldown, etc, maybe it comes down to personal preference but I love decks (since you can just eVoke them like wands now) and multiple miscs.


This hasn't been the case since .17 or earlier. Nowadays all phials share the same cooldown period.

It's still useful to carry multiple decks, bobs, sacks, or mirrors. Just not the elemental evokers.



ahhhh, did not know this. haven't found multiples in a while (or rather haven't needed to evoke a second one in the time it would cooldown)
User avatar

Vestibule Violator

Posts: 1509

Joined: Wednesday, 21st September 2011, 01:10

Location: St. John's, NL, Canada

Post Thursday, 23rd June 2016, 21:28

Re: Fix auto-pickup multiple Misc

xbon wrote:
Shtopit wrote:Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

this auto pickup does what you want...


once you pick up one of a certain type of ring <magic resistance, poison resistance, etc> it takes the rest off auto pickup (it'll also try and pick up any valid item slot that you don't have equipped, and if yours isn't branded it'll look for a branded version, etc.) kudos to rchandra and Medar for making it.




Sadly that one just works on armours, the ring problem is more difficult especially as Octopodes, Ru, and the macabre necklace all exist. You might be better off just setting all known rings to not pick-up, then manually getting the duplicates that you want. I just use \ each time, so far.
Won all race/bg, unwon (online): Nem* Hep Uka
Favourites: 15-rune Trog, OgNe/OgIE/OgSu (usually Ash), Ds, Ru, SpEn, Ce of Chei, Qaz

Ziggurat Zagger

Posts: 4055

Joined: Tuesday, 10th January 2012, 19:49

Post Thursday, 23rd June 2016, 21:30

Re: Fix auto-pickup multiple Misc

If you set autopickup exceptions to not pick up "ring of" then you won't autopickup type-identified rings. You can then either set further exceptions for the rings you do want to pick up (ring of slaying, protection, etc.) or just pick them up manually.

Ziggurat Zagger

Posts: 8786

Joined: Sunday, 5th May 2013, 08:25

Post Thursday, 23rd June 2016, 21:39

Re: Fix auto-pickup multiple Misc

crate wrote:If you set autopickup exceptions to not pick up "ring of" then you won't autopickup type-identified rings. You can then either set further exceptions for the rings you do want to pick up (ring of slaying, protection, etc.) or just pick them up manually.
this is actually how the default autopickup works for amulets; the problem is, monsters can wear rings and amulets and identify them and then autopickup misses them. monster jewellery is such a good addition to the game!!

For this message the author duvessa has received thanks:
crate

Lair Larrikin

Posts: 29

Joined: Thursday, 13th March 2014, 16:44

Post Thursday, 23rd June 2016, 23:11

Re: Fix auto-pickup multiple Misc

rchandra wrote:
xbon wrote:
Shtopit wrote:Is there a way to change which items are auto-picked up in-game? Like saying, I already have rings which give me magic resistance, stop picking them?

this auto pickup does what you want...


once you pick up one of a certain type of ring <magic resistance, poison resistance, etc> it takes the rest off auto pickup (it'll also try and pick up any valid item slot that you don't have equipped, and if yours isn't branded it'll look for a branded version, etc.) kudos to rchandra and Medar for making it.




Sadly that one just works on armours, the ring problem is more difficult especially as Octopodes, Ru, and the macabre necklace all exist. You might be better off just setting all known rings to not pick-up, then manually getting the duplicates that you want. I just use \ each time, so far.


you sure? because once I id a ring and have it equipped it doesn't pick up the other ones of that exact type, don't have anything else that would modify my autopickups, no current exceptions set.

Tomb Titivator

Posts: 853

Joined: Thursday, 29th August 2013, 18:39

Post Friday, 24th June 2016, 20:40

Re: Fix auto-pickup multiple Misc

Why do multiples of elemental evokers spawn again?

Slime Squisher

Posts: 395

Joined: Monday, 28th April 2014, 19:50

Post Saturday, 25th June 2016, 08:56

Re: Fix auto-pickup multiple Misc

johlstei wrote:Why do multiples of elemental evokers spawn again?

The game spawns plenty of things that the player doesn't care about. You can get duplicate amulets, naga bardings on non-nagas, scrolls of blinking on formicids...
User avatar

Ziggurat Zagger

Posts: 4478

Joined: Wednesday, 23rd October 2013, 07:56

Post Saturday, 25th June 2016, 09:12

Re: Fix auto-pickup multiple Misc

genericpseudonym wrote:
johlstei wrote:Why do multiples of elemental evokers spawn again?

The game spawns plenty of things that the player doesn't care about. You can get duplicate amulets, naga bardings on non-nagas, scrolls of blinking on formicids...

Also, if you are in a portal vault and are out of inventory space, you can drop an elemental evoker there if you know that you have another one waiting for you in the dungeon.

This has never happened to me, but it could be possible.
DCSS: 97:...MfCj}SpNeBaEEGrFE{HaAKTrCK}DsFESpHu{FoArNaBe}
FeEE{HOIEMiAE}GrGlHuWrGnWrNaAKBaFi{MiDeMfDe}{DrAKTrAMGhEnGnWz}
{PaBeDjFi}OgAKPaCAGnCjOgCKMfAEAtCKSpCjDEEE{HOSu
Bloat: 17: RaRoPrPh{GuStGnCa}{ArEtZoNb}KiPaAnDrBXDBQOApDaMeAGBiOCNKAsFnFlUs{RoBoNeWi

Return to Game Design Discussion

Who is online

Users browsing this forum: No registered users and 19 guests

cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group.
Designed by ST Software for PTF.