Goldify spellbooks working patch?


Although the central place for design discussion is ##crawl-dev on freenode, some may find it helpful to discuss requests and suggestions here first.

bel

Dis Charger

Posts: 2083

Joined: Tuesday, 3rd February 2015, 22:05

Post Saturday, 4th February 2017, 15:44

Goldify spellbooks working patch?

According to a comment here, there is interest for patches which goldify spellbooks. I made a (buggy) patch here for normal crawl - the bugs were fixed in hellcrawl. Perhaps that fix be implemented in normal crawl as well?

While we're at it, can we make Vehumet gift artifact spellbooks with one spell, instead of using the "M" screen?

For this message the author bel has received thanks: 9
amaril, Arrhythmia, dracos369, duvessa, Factorialite, nago, VeryAngryFelid, WingedEspeon, yesno

Crypt Cleanser

Posts: 714

Joined: Saturday, 5th December 2015, 06:56

Post Saturday, 4th February 2017, 17:35

Re: Goldify spellbooks working patch?

+1'd

bel

Dis Charger

Posts: 2083

Joined: Tuesday, 3rd February 2015, 22:05

Post Friday, 4th August 2017, 06:26

Re: Goldify spellbooks working patch?

Bump this thread.

Doesnt created a patch (putting all spells in a library). It has been implemented in hellcrawl for some time now, and seems to be working fine. It could be implemented in normal crawl as well: as I linked above, there was already interest in the idea and just the work needed to be done. Well, it is, now.

For this message the author bel has received thanks: 2
nago, Shtopit
User avatar

Vestibule Violator

Posts: 1579

Joined: Saturday, 18th June 2016, 13:57

Post Friday, 4th August 2017, 08:40

Re: Goldify spellbooks working patch?

This would be a wonderful improvement. There are many reasons why spellbooks shouldn't be inventory items, the most important ones being:
#1. The difficulty in telling which books contain which spells, which to drop, and which overlap, rendering others useless.
#2. The fact that books are strategic items, which essentially means that you can (or should) drop them anywhere and go back to them later, which brings to stashing, boring trips, and ruins the game flow.
#3. If you don't want trips or stashing, you must carry them around and suffer inventory strain.
I Feel the Need--the Need for Beer
Spoiler: show
3DsBeTr, 15DsFiRu, 3DsMoNe, 3FoHuGo, 3TrArOk, 3HOFEVe, 3MfGlOk, 4GrEEVe, 3BaIEChei, 3HuMoOka, 3MiWnQaz, 3VSFiAsh, 3DrTmMakh, 3DsCKXom, 3OgMoOka, 3NaFiOka, 3FoFiOka, 3MuFEVeh, 3CeHuOka, 3TrMoTSO, 3DEFESif, 3DsMoOka
User avatar

Blades Runner

Posts: 543

Joined: Monday, 24th April 2017, 11:46

Post Friday, 4th August 2017, 21:03

Re: Goldify spellbooks working patch?

Now what mines will Berserkers drop under the feet of their enemies?
But, honestly, I don't worship Trog very often, and I like the idea of goldifying books.
Maɟaŋ

Blades Runner

Posts: 612

Joined: Saturday, 12th December 2015, 23:54

Post Saturday, 5th August 2017, 00:29

Re: Goldify spellbooks working patch?

The only complaints I've heard about goldified books are related to sorting. The spell list can get kind of cumbersome late in the game on characters that train lots of magic skills. I'd like to see it in mainline crawl with options to sort by spell level or spell school, or maybe a search function. Then I can steal those options for hellcrawl without having to do any work myself. Thank you in advance.

E: please do the Vehumet thing too.
Remove spell hunger.

Dungeon Master

Posts: 325

Joined: Monday, 18th August 2014, 20:04

Post Saturday, 5th August 2017, 01:27

Re: Goldify spellbooks working patch?

There's an incomplete PR here from Doesnty, which has some dev comments indicating what else needs to be done. The code also hasn't been vetted in detail as far as I know so there may be further specific problems (just looking at the commit history it needs some rebasing at least). I think this will/would get merged, but it'll need someone to steward it through the rest of the process, which is typically the most detail-oriented and tedious part of this kind of project; I don't think the amount of work left is trivial. Recent drama + the fact that he closed the PR seems to suggest that this person likely won't be Doesnty. It may be a dev (I might be willing to do it myself at some point once I've finished some other projects) but there's been no immediate volunteers that I know of.

For this message the author advil has received thanks:
Shtopit

Slime Squisher

Posts: 399

Joined: Thursday, 16th June 2011, 18:36

Post Saturday, 5th August 2017, 15:29

Re: Goldify spellbooks working patch?

If there's an effort to make a spell library, I would suggest a filter-by-school approach rather than sort-by-school.

Filter: (*) Show All / (A)ir / (C)harms / Con(j)uration / (E)arth / (F)ire / (H)exes / (I)ce / (N)ecromancy / (P)oison / (S)ummoning / (T)ranslocation / Trans(m)utation
Won with: KeAE^Sif, NaWz^Sif, NaTm^Chei, SpEn^Nmlx, GrEE^Qaz, HOFE^Veh, MiBe^Trog, DrFE^Hep, FoFi^Zin, CeHu^Oka.
In Progress: GnSk.
Long-term goal: complete the pantheon.

For this message the author mattlistener has received thanks: 2
Doesnt, VeryAngryFelid

Return to Game Design Discussion

Who is online

Users browsing this forum: Majestic-12 [Bot] and 6 guests

Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group.
Designed by ST Software for PTF.