Allow armour to be searched with "armor"


Although the central place for design discussion is ##crawl-dev on freenode, some may find it helpful to discuss requests and suggestions here first.

Lair Larrikin

Posts: 29

Joined: Thursday, 13th March 2014, 16:44

Post Tuesday, 17th May 2016, 20:56

Allow armour to be searched with "armor"

since it isn't in my native english to write armour when I ctrl + f I always end up having to re-search for armour, I was wondering if it'd be not too much trouble to maybe add an armor tag that lets them be searched that way as well?

For this message the author xbon has received thanks: 7
andreas, Malevolent, nago, Rast, Sar, Tiktacy, yesno
User avatar

Halls Hopper

Posts: 89

Joined: Monday, 11th April 2016, 21:48

Post Wednesday, 18th May 2016, 09:07

Re: Allow armour to be searched with "armor"

I've learned to just search for "armo". Try it out! I believe it doesn't turn up any false positives.

If this were to be fixed, I think a broader solution would be better, such as the game interpreting "o" as a match for "ou" in all cases, in the event the user needs to search for favou?r, splendou?r, colou?r, or odou?r.
remove handsome distillation

For this message the author pumpyscump has received thanks:
xbon
User avatar

Zot Zealot

Posts: 982

Joined: Monday, 29th September 2014, 09:04

Post Wednesday, 18th May 2016, 09:32

Re: Allow armour to be searched with "armor"

Those who abandon the commonwealth deserve to suffer.

For this message the author chequers has received thanks: 2
casserol, TeshiAlair

Lair Larrikin

Posts: 29

Joined: Thursday, 13th March 2014, 16:44

Post Saturday, 21st May 2016, 04:25

Re: Allow armour to be searched with "armor"

pumpyscump wrote:I've learned to just search for "armo". Try it out! I believe it doesn't turn up any false positives.

If this were to be fixed, I think a broader solution would be better, such as the game interpreting "o" as a match for "ou" in all cases, in the event the user needs to search for favou?r, splendou?r, colou?r, or odou?r.


yeah, I end up usually stopping myself and just typing armo; if possible it would be insanely convenient if o was treated as both o and ou for search cases.

Dungeon Master

Posts: 1051

Joined: Thursday, 12th June 2014, 05:19

Post Tuesday, 24th May 2016, 16:47

Re: Allow armour to be searched with "armor"

i tried to implement the op's suggestion, but it turned out to be surprisingly hard, so i gave up. Patches Welcome

For this message the author PleasingFungus has received thanks:
xbon

Dungeon Master

Posts: 3618

Joined: Thursday, 23rd December 2010, 12:43

Post Tuesday, 24th May 2016, 16:50

Re: Allow armour to be searched with "armor"

PleasingFungus: Wouldn't it be easier for players to learn correct English, rather than us fixing their spelling deficiencies?

For this message the author dpeg has received thanks:
Rast
User avatar

Barkeep

Posts: 4435

Joined: Tuesday, 11th January 2011, 12:28

Post Tuesday, 24th May 2016, 17:05

Re: Allow armour to be searched with "armor"

I know that's a joke, but... how does search work in crawl's internationalization? en-us and en-gb and en-au are generally considered different localizations.
I am not a very good player. My mouth is a foul pit of LIES. KNOW THIS.
User avatar

Vestibule Violator

Posts: 1591

Joined: Saturday, 3rd August 2013, 18:59

Post Tuesday, 24th May 2016, 17:27

Re: Allow armour to be searched with "armor"

dpeg wrote:PleasingFungus: Wouldn't it be easier for players to learn correct English, rather than us fixing their spelling deficiencies?


Many computers don't consider "armour" to be the correct spelling, in fact as I'm typing this there is a red line underneath the word telling me its not spelled properly. I still spell it armour though because to me that makes more sense in terms of pronunciation.
To all new players: Ignore all strategy guides posted on the wiki, ask questions in the Advice forum, players with lots of posts normally have the best advice.

crawl.akrasiac.org:8080 <- take this link to play online or spectate.

For this message the author Tiktacy has received thanks:
Shard1697

Tomb Titivator

Posts: 885

Joined: Sunday, 28th June 2015, 14:44

Post Tuesday, 24th May 2016, 18:23

Re: Allow armour to be searched with "armor"

dpeg wrote:PleasingFungus: Wouldn't it be easier for players to learn correct English, rather than us fixing their spelling deficiencies?

dpeg: If you can show us a single, universally accepted spelling of the word "armour", then maybe your comment here wouldn't sound so rude.

For this message the author ydeve has received thanks:
green

Ziggurat Zagger

Posts: 8786

Joined: Sunday, 5th May 2013, 08:25

Post Tuesday, 24th May 2016, 18:58

Re: Allow armour to be searched with "armor"

poor dpeg. misses every joke, has all of his own jokes missed

For this message the author duvessa has received thanks:
PleasingFungus

Sar

User avatar

Ziggurat Zagger

Posts: 6418

Joined: Friday, 6th July 2012, 12:48

Post Tuesday, 24th May 2016, 19:38

Re: Allow armour to be searched with "armor"

I'm sure nobody will miss that particular joke.
User avatar

Dungeon Master

Posts: 502

Joined: Wednesday, 7th March 2012, 13:25

Location: Lexington, KY, US

Post Tuesday, 24th May 2016, 19:49

Re: Allow armour to be searched with "armor"

Added in trunk. Note that Ctrl-F dragon armor still doesn't work, because we're only translating the slot annotation ("{body armor}" "{gloves armor}" etc.), and not the item's actual name.

For this message the author neil has received thanks: 3
PleasingFungus, Shard1697, xbon

Dungeon Master

Posts: 3618

Joined: Thursday, 23rd December 2010, 12:43

Post Tuesday, 24th May 2016, 19:51

Re: Allow armour to be searched with "armor"

neil: but you could do "dragon && armor"?

Ziggurat Zagger

Posts: 8786

Joined: Sunday, 5th May 2013, 08:25

Post Tuesday, 24th May 2016, 19:59

Re: Allow armour to be searched with "armor"

Sar wrote:I'm sure nobody will miss that particular joke.
two people just did
User avatar

Dungeon Master

Posts: 502

Joined: Wednesday, 7th March 2012, 13:25

Location: Lexington, KY, US

Post Tuesday, 24th May 2016, 20:00

Re: Allow armour to be searched with "armor"

dpeg wrote:neil: but you could do "dragon && armor"?


Yes, but that will also give you hides.

Abyss Ambulator

Posts: 1217

Joined: Sunday, 14th April 2013, 04:01

Post Tuesday, 24th May 2016, 20:59

Re: Allow armour to be searched with "armor"

I have actually switched to using armour in all cases in life thanks to this game.

#ThanksCrawlbama
Three wins: Gargoyle Earth Elementalist of Ash, Ogre Fighter of Ru, Deep Dwarf Fighter of Makhleb (0.16 bugbuild :( )

Spider Stomper

Posts: 206

Joined: Wednesday, 12th January 2011, 15:07

Post Friday, 3rd June 2016, 13:06

Re: Allow armour to be searched with "armor"

duvessa wrote:
Sar wrote:I'm sure nobody will miss that particular joke.
two people just did


I though Sar made a joke (that no one would miss dpeg's joke if it were gone). But maybe I missed the joke. The joke has many layers, like an ogre.

For this message the author Zooty has received thanks:
Sar

Return to Game Design Discussion

Who is online

Users browsing this forum: No registered users and 100 guests

cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group.
Designed by ST Software for PTF.