Don't let players waste scrolls of curse weapon

[esran]

Pretty self explanatory. Don't let the player read a scroll of curse weapon when it would be useless, if they have it identified. The game already does this with blinking and stasis, so I don't think its unreasonable.

[johlstei]

I guess it kind of goes without saying that this should also apply to curse armour and jewelry.

[XuaXua]

IMHO, idiot-proofing patches are always welcome.

[Hirsch I]

IMHO, idiot-proofing patches are always welcome.

as someone who has problems with baby-proof doors, I agree.

[neil]

Curse Armour and Curse Jewellery already prevent casting when there are no cursables, so only Curse Weapon needs to be fixed. It wouldn't be quite the same implementation, though, since those two have item-selection menus where Curse Weapon does not.

IMO the inconsistency with the other two curse scrolls justifies calling this a bug and posting it on Mantis.

[esran]

Problems with curse scrolls have been grandfathered in from when curse scrolls were a thing that could happen to someone who doesn't worship ash. As this is no longer the case, I see no reason why scrolls of cursing shouldn't be able to effect any item of their type, even ones not equipped, as long as that item is not already cursed. I also see no reason why they shouldn't be cancelable, like identify when it is identified. I also see no reason why curse weapon, and only curse weapon, should be wasteable.
However, I am not willing to go through the effort of posting it to mantis. *shrugs*

[PleasingFungus]

It's not very much effort to post something to mantis, you know.

Moot now in any case; I ended up handling this when I rewrote the scroll-reading code just now. You should be good to go.