Tiles lighting rework

[Bodrick]

I've been working on a tiles lighting rework for the last week or so with the aim of making the lighting in crawl a bit more dynamic. I've pretty much got it to a point where it's good for a first release at least, so the devs asked me to get some player feedback while they set up an experimental branch.

Main differences my changes make:
* Tile lighting slightly blends from one tile to adjacent tiles (most noticeable with LOS transitions)
* Tiles close to you are slightly lightened
* Halos and umbras overlap slightly
* Lava will light adjacent tiles slightly
* Hybrid mode looks a bit cooler

Some ways this could be expanded further without too much effort:
* Wall torches give off light
* Branch specific lighting
* Spell lighting


Some examples:

Spoiler: show

Dungeon:


Shoals:


Volcano + halo + Dithmenos umbra + orb glow:


Hybrid:

The blending effect can be controlled with an rcfile option, so can be disabled if a player doesn't like, or equally can be increased to smooth out the transition further. I've tried to keep a good balance of being able to tell if a tile is in LOS or not, while still being able to keep a relatively smooth lighting transition.

So, what do you all think?

[Siegurt]

I for one like the way that looks a lot.

[Sprucery]

Yeah, I'll be looking forward to the next time I'll get a Dith worshipper with the Orb to a rendezvous with an Angel in a Volcano :)

[tedric]

I think it mostly looks OK, but it's hard to know without playing it and seeing how it looks "in motion".

One weird thing is that the light of walls that are in LOS brightens even the side that is blocked from LOS in a counter-intuitive way -- in your first screenshot, the light on the wall segment to the left of the rat seems to wrap all the way around to the unseen side -- while at the same time, out-of-LOS tiles spill over their shadows in a way that creates a chunky offset in the blending pattern (most obvious in the Shoals screenshot). I think it would look more natural if walls edges had a hard boundary with out-of-LOS and unexplored tiles, while edges bordering open spaces (floor, water, lava, features) used the blending effect.

[wizzzargh]

It looks really nice in ascii, reminds me of Brogue

[savageorange]

Interesting. But these screenshots are all webtiles, how does normal offline tiles look? (this is necessary to inform my vote, as I don't want to promote further differences between webtiles and offline)

And I guess while I'm asking, is console affected at all? (I wouldn't think so, but I can also think of a few things that could be done with lighting code in console -- drawing lit tiles in bold, for example.)

[Bodrick]

Offline tiles has the same effect, and there's no changes to console.
I changed the blending slightly yesterday so non-opaque tiles don't blend into opaque tiles, which I think looks a bit more natural (see the walls closest to my character):

[savageorange]

With that change, it's looking a lot better; you've got my vote.

[njvack]

I play console but damn, that looks really great. Honestly, the tiles art in Crawl is generally really good.

[Moose]

How does one enable the hybrid mode in the webtiles UI? That looks incredible?

[Bodrick]

How does one enable the hybrid mode in the webtiles UI? That looks incredible?

There's a tile_display_mode rc option that can be set to tiles, hybrid, or glyphs.

[Sar]

My problem with that would be that it looks like there is some mechanic behind this, but there is none.