Which mace to chose.

[siprus]

So i have whip of electro cution +0, +1 Mace of protection +0, +3 and morning star of freezing -1, +2.

Which one is best? My mace skill is 10.

[MoogleDan]

Unless you're mysteriously playing a stealth M&Fer, whip.

[pratamawirya]

If I'm playing a melee dude, then I'll use both the whip and the morningstar. The whip is pretty nice, though I probably won't enchant it. Freezing is also a good brand, especially against cold-blooded dudes.

[Lasty]

Due to what might be a bug, brands don't add noise to melee. The only exception is the electrical explosion that happens on elec brand triggers against targets in water.

[Siegurt]

Due to what might be a bug, brands don't add noise to melee. The only exception is the electrical explosion that happens on elec brand triggers against targets in water.

Actually that's not true. Brands alter the base multiplier for melee weapon noise, however this has a cap (the same cap as shouting) Electricity adds more noise than other brands.

Brands don't add any additional noise when they do damage though, they just alter the amount of damage that the regular weapon noise makes.

  Code:

    case SPWPN_ELECTROCUTION:
        noise_factor += 800 / max(1, damage_done);


  Code:


    int level = noise_factor * damage_done / 100 / 4;

    if (noise_factor > 0)
        level = max(1, level);

    // Cap melee noise at shouting volume.
    level = min(12, level);

    if (level > 0)
        noisy(level, pos, attacker->mindex());

    noise_factor = 0;


[Amnesiac]

So i have whip of electro cution +0, +1 Mace of protection +0, +3 and morning star of freezing -1, +2.

Which one is best? My mace skill is 10.

at 10 it's the whip, but you'd want to bring it to 12 so it would be at the mindelay, morningstar is for targets that resist electicity, obviously, but you could bring your M&F to a higher level and that mace could be your all-purpose weapon, especially if you have a high str. Or just leave M&F at 12 and train something else that you need.

[Lasty]

Actually that's not true. Brands alter the base multiplier for melee weapon noise, however this has a cap (the same cap as shouting) Electricity adds more noise than other brands.

Brands don't add any additional noise when they do damage though, they just alter the amount of damage that the regular weapon noise makes.

You're right that that seems to be the intended effect of the code, but due to what might be a bug, it doesn't actually happen. Before the call to handle_noise(), there's a call to adjust_noise(), which (at least in the version I have code for) overwrites the noise values set by the brand.

If it did work, it would execute this addition:

  Code:

noise_factor += 800 / max(1, damage_done);

Which is silly, because the higher the damage done is, the lower the added noise factor is. I'm guessing no one has noticed just because melee combat noise is pretty difficult to perceive anyway.

[Siegurt]

Sorry, you're correct, that bit is executed by the setting up of the brand damage, which actually happens (a bit counterintuitively) during the "is hit" phase, prior to doing the weapon damage the adjust_noise function (Which alters the noise_factor for base weapon noise) then overwrites the noise_factor prior to actually handling the noise itself.

Note that the noise factor is *multiplied* by the damage done, so the +=(800/damage done), if it worked and wasn't simply overwritten, it would effectively add 800 to the noise factor (which is then divided by 400, so effectively it would add two to the final noise level, on a scale where 12 is the cap and equivalent to shouting)

[Lasty]

Note that the noise factor is *multiplied* by the damage done, so the +=(800/damage done), if it worked and wasn't simply overwritten, it would effectively add 800 to the noise factor (which is then divided by 400, so effectively it would add two to the final noise level, on a scale where 12 is the cap and equivalent to shouting)

Ah, gotcha -- I didn't follow it through to that part. That's good to know, in case weapon brand noise ever gets fixed.

[Siegurt]

Added:

https://crawl.develz.org/mantis/view.php?id=7526

If you were curious