Whitespace

[BlackSheep]

I notice a lot of commits involve the devs with commit rights tidying up stray whitespace from submitted patches. Can anyone offer tips to reduce the need for this? Do you guys just scan the diff looking for extra spaces or is there a script I could write/run that looks for it?

[galehar]

util/checkwhite

[neil]

Just run utils/checkwhite from the source directory. It will fix all the problems it finds, though sometimes it incorrectly guesses what you meant by a tab (eight spaces or four).

Other formatting fixes (brace usage, indentation of multi-line expressions, and so on; see docs/develop/coding_conventions.txt) are usually identified and corrected by hand.

[BlackSheep]

When I run checkwhite under msysgit it seems to remove all carriage returns. Then when I commit changes, I get "warning: LF will be replaced by CRLF in crawl-ref/source/newgame.cc."

Is that just a quirk of windows or is there a setting I can change to make the CR/LF more consistent?

[galehar]

You need to set autocrlf = false in git config.
That way, line endings are kept in unix format and checkwhite won't mess with them.