Page 1 of 1

Change level annotations from Dungeon Overview

PostPosted: Thursday, 19th June 2014, 22:29
by ensis
I have some spare time so looked for a requested feature in the wiki (User Interface Implementable List). I picked "Change level annotations from Dungeon Overview (Ctrl-O)" and coded it. Halfway done, functionality is there but testing, polish and comments are missing.

Now I ask myself if I can just pick stuff and post patches like that. Is that part of the wiki even for people like me or is it meant for regular developers? Are the items still wanted? Maybe I should start a discussion in the "Game Design Discussions" forum first? Is it likely that none of the regulars already started a feature from there?

In short, what are the best practices here when I want to code requested and approved features from the wiki?

Re: Change level annotations from Dungeon Overview

PostPosted: Thursday, 19th June 2014, 22:44
by dpeg
Yes, this is still wanted.

If you feel your patch is ready, just upload it to Mantis. If not, it's probably best to go to IRC ##crawl-dev and ask. Many thanks!

Re: Change level annotations from Dungeon Overview

PostPosted: Thursday, 19th June 2014, 22:46
by Kate
The wiki page is very old and some of the features there might not be desirable any more (this is true for much of the devwiki - it's useful for lengthy concepts and longer-term ideas but those often end up out of date pretty fast).

For that particular suggestion, for example, it's not actually true that you need to travel to a level to annotate it (you can annotate levels while viewing them with X -> G). If it's possible to implement without making the Ctrl-O screen too cluttered it could still be good to have though - in principle getting ideas from there is definitely fine, it's just probably worth double-checking that the idea is still relevant by posting in GDD or asking in ##crawl-dev.

Re: Change level annotations from Dungeon Overview

PostPosted: Friday, 20th June 2014, 08:44
by ensis
Thanks for the info. I submitted my patch.