Recolor bonus from manuals

[papilio]

Why "red"?

It seems I'm being penalized by god or my skill training is subdued or etc.

[PleasingFungus]

what colour do you want?

[dracos369]

Bright orange?

[bel]

Used to be green IIRC?

[Shard1697]

Yeah, green seems good to me... every time I see the red I feel for a second like there's some problem I need to correct.

[dracos369]

Yeah, but green is now used for crosstrained skills for some reason.

[Sar]

Golden.

[Brannock]

Outer space.

[ZipZipskins]

Neon black.

[PleasingFungus]

for reference

  Code:

    // Skills being actively trained may get further distinction.
    bool use_bright_colour = you.train[m_sk] == TRAINING_ENABLED
        || you.train[m_sk] == TRAINING_FOCUSED;

    if (is_set(SKMF_HELP))
        return DARKGREY;
    else if (is_set(SKMF_RESKILL_TO) && m_sk == you.transfer_from_skill)
        return BROWN;
    else if (skm.get_state(SKM_VIEW) == SKM_VIEW_TRANSFER
             && (m_sk == you.transfer_from_skill
                 || m_sk == you.transfer_to_skill))
    {
        return CYAN;
    }
    else if (skm.get_state(SKM_LEVEL) == SKM_LEVEL_ENHANCED
             && (you.skill(m_sk, 10, true) != you.skill(m_sk, 10, false)
                 // Drained a tiny but nonzero amount.
                 || you.attribute[ATTR_XP_DRAIN] && you.skill_points[m_sk]))
    {
        if (you.skill(m_sk, 10, true) < you.skill(m_sk, 10, false))
            return use_bright_colour ? LIGHTGREEN : GREEN;
        else
            return use_bright_colour ? LIGHTMAGENTA : MAGENTA;
    }
    else if (mastered())
        return YELLOW;
    else if (!you.training[m_sk])
        return DARKGREY;
    else if (skill_has_manual(m_sk))
    {
        if (is_set(SKMF_APTITUDE))
            return LIGHTRED;
        return use_bright_colour ? LIGHTRED : RED;
    }
    else if (you.train[m_sk] == TRAINING_FOCUSED)
        return WHITE;
    else
        return LIGHTGREY;

colours used:
darkgrey (inactive, help mode)
yellow (mastered)
brown/cyan (ash skill transfer)
green/lightgreen (crosstrained)
lightmagenta/magenta (drained)
lightred/red (manuals)
white (focused)
lightgrey (default)

colours not used:
- lightcyan
- blue/lightblue
- black (not a good idea)

[ZipZipskins]

I feel like blue would definitely be better than red for this.

[PleasingFungus]

iirc some console players said that dark blue text was hard to read on their screens? someone find a console player to confirm/deny; i'll change it if it's not a problem.

[twelwe]

i hate this dark blue text crap! but love it on the map!

[bel]

I find dark blue somewhat hard to read, but not overly so. Not a big deal if it isn't changed.

[VeryAngryFelid]

Change draining to red.

[thevogonpoet]

Console player reports: the dark blue is indeed hard to read in Putty. I tried Tedronai's rc file adjustment,but it didn't seem to do anything, so I gave up. decided it wasn't too hard to read, and just lived with it.

The manual colour does seem a bit weird.

[Siegurt]

Console player reports: the dark blue is indeed hard to read in Putty. I tried Tedronai's rc file adjustment,but it didn't seem to do anything, so I gave up. decided it wasn't too hard to read, and just lived with it.

The manual colour does seem a bit weird.

Note that in putty, specifically, you can change the color of "blue" to be anything you want.

[Airwolf]

I find dark blue somewhat hard to read, but not overly so. Not a big deal if it isn't changed.

I concur.

How about lightblue or lightcyan?

[TeshiAlair]

Some recent update changed things from darkgrey to darkblue and I hate it so so so so much.

Lightblue for manuals sounds fine.

[PleasingFungus]

OK, done.

[ZipZipskins]

Guess the colour red was too tolkieny too

[Shtopit]

Guess the colour red was too tolkieny too

Bilbo's Little Red Book. From when he defeated the Nationalist Party led by Otho Sackville-Baggins in the Hobbit Civil War and imposed a Revolutionary Government on the Shire. Good times.

[PleasingFungus]

hrm, turns out there was a very specific reason manuals turned red. not reverting yet, but will have to mull this over further...

[ZipZipskins]

iratecat suggested upthread making draining red and thus manuals magenta. I still think this would be preferable to manuals being red if blue ends up not being an option