|Anonymous | Login | Signup for a new account||2019-02-22 18:29 CET|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0009926||[DCSS] Bug Report||minor||always||2015-08-26 23:37||2015-10-26 16:18|
|Status||resolved||Product Branch||0.17 ancient branch|
|Summary||0009926: Unify search terms.|
As per https://crawl.develz.org/tavern/viewtopic.php?f=8&t=17465. [^]
Currently the search function does not work reliably with one search term for all items who have the desired quality. I propose to get rid of these cases.
Currently known to me:
Search for rcorr will give artifacts with rcorr, but not amulet of corrosion resistance.
Search for mr+ will give artifacts with mr+, but not ring of protection from magic.
|Tags||No tags attached.|
I was going to suggest searching by the descriptive string instead, but even that is not consistent, and it doesn't work anyway:
Cloak of MR: "It increases its wearer's resistance to enchantments."
Ring of protection from magic: "This ring increases its wearer's resistance to hostile enchantments."
Artefact with MR: "It affects your resistance to hostile enchantments."
But then ctrl-f resistance.*enchantments doesn't match the cloak or ring :(
edited on: 2015-08-26 23:56
I guess the solution would be to have dat/clua/stash.lua add prefixes based on the pseudo-inscriptions for the various egos/ring types (since you wouldn't want to actually have pseudo-inscriptions on every ego item and piece of jewellery). But I don't know if clua is actually able to get the subtype or brand in all relevant cases. It could be done on the C++ side from stash_annotate_item instead.
It would also be nice if menu prefixes and stash search prefixes were unified, so that the new prefixes could be used for menu colouring, too (and so that you could do things like ctrl-f unidentified).
I worked on this a month ago, hopefully fixed by the following commits:
If there are still cases where things don't work as expected, please open a new bug report.
|2015-08-26 23:37||Le_Nerd||New Issue|
|2015-08-26 23:48||neil||Note Added: 0029428|
|2015-08-26 23:54||neil||Note Added: 0029429|
|2015-08-26 23:56||neil||Note Edited: 0029429|
|2015-10-26 15:07||Medar||Note Added: 0029672|
|2015-10-26 15:07||Medar||Status||new => resolved|
|2015-10-26 15:07||Medar||Fixed in Branch||=> 0.17 development branch|
|2015-10-26 15:07||Medar||Resolution||open => done|
|2015-10-26 15:07||Medar||Assigned To||=> Medar|
|2015-10-26 16:18||Le_Nerd||Note Added: 0029673|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|