|
Viewing Issue Simple Details
[ Jump to Notes ]
[ Wiki ]
|
[ View Advanced ]
[ Issue History ]
[ Print ]
|
|
ID |
Category |
Severity |
Reproducibility |
Date Submitted |
Last Update |
|
0009635 |
[DCSS] Bug Report |
minor |
always |
2015-04-15 03:24 |
2015-11-01 02:38 |
|
|
Reporter |
PleasingFungus |
View Status |
public |
|
|
Assigned To |
wheals |
|
Priority |
normal |
Resolution |
done |
|
|
Status |
resolved |
|
Product Branch |
0.17 ancient branch |
|
|
Summary |
0009635: Phantom mirrored uniques cause buggy notes on 'death' |
|
Description |
E.g., after phantom mirroring the royal jelly:
16182 | Slime:6 | your royal jelly (ally) was killed
16182 | Slime:6 | Your ally died
The latter is NOTE_ALLY_DEATH, the former is NOTE_DEFEAT_MONSTER. Neither of these notes should appear, but the latter (with the missing name) is especially annoying.
I'm told this behaviour was intended for yred-enslaved uniques, where it makes more sense. However, when tested, yred slaves don't generate NOTE_DEFEAT_MONSTERs; probably it's safe to filter summoned monsters out of that category. Not sure what to do about NOTE_ALLY_DEATH... |
|
Additional Information |
|
| Tags |
No tags attached. |
|
|
Attached Files |
 9635.patch [^] (929 bytes) 2015-10-31 21:55 [Show Content] [Hide Content]From efab32778bd7628982381f5f49eaa363d8957bf5 Mon Sep 17 00:00:00 2001
From: "Edgar A. Bering IV" <trizor@gmail.com>
Date: Sat, 31 Oct 2015 15:52:19 -0500
Subject: [PATCH] Don't buggily note defeats of summoned interesting monsters
(9635).
---
crawl-ref/source/mon-death.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crawl-ref/source/mon-death.cc b/crawl-ref/source/mon-death.cc
index efbda57..3f1f04a 100644
--- a/crawl-ref/source/mon-death.cc
+++ b/crawl-ref/source/mon-death.cc
@@ -506,7 +506,7 @@ void record_monster_defeat(monster* mons, killer_type killer)
return;
if (mons->has_ench(ENCH_FAKE_ABJURATION))
return;
- if (MONST_INTERESTING(mons))
+ if (MONST_INTERESTING(mons) && !mons->is_summoned())
{
take_note(Note(NOTE_DEFEAT_MONSTER, mons->type, mons->friendly(),
mons->full_name(DESC_A).c_str(),
--
2.3.2 (Apple Git-55)
|
|
|
