Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0009601 [DCSS] Bug Report minor have not tried 2015-04-01 05:34 2015-04-01 16:58
Reporter Glenstorm View Status public  
Assigned To wheals
Priority normal Resolution done  
Status resolved   Product Branch experimental branch
Summary 0009601: Pizza in wrong alphashop
Description It should probably be in 'P' for pizza rather than 'S' for slice.

Or perhaps 'T' in honor of pizza tornado.
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0028752)
nicolae (reporter)
2015-04-01 05:45
edited on: 2015-04-01 05:48

Oof. When assigning items to shops, there was a question of what to do with items named "blank of whatever", where "blank" wasn't some sort of item class (like "amulet" or "ring") -- items like "slice of pizza" or "lantern of shadows", where the word before the "of" is pretty much unique to that item.

Three options:
1) Alphabetize based on the word before the "of" (the current option)
2) Alphabetize based on the word after the "of" (what's done for amulets, rings, wands, etc.)
3) Alphabetize based on both (and put slices of pizza in both the S and P shops)

I'm kind of inclined to go with 1 on the extremely convincing basis of "involves no work on my part" but I can see arguments for 2 and 3. I do prefer 3, if I'm going to do any changes to alphashops I'd probably just do that.

(0028753)
Glenstorm (reporter)
2015-04-01 06:00
edited on: 2015-04-01 06:04

Hmm it's interesting, I'm actually naturally okay with option 1 for almost every item but pizza. Crystal ball of energy and Lantern of Shadows feel fine in 'C' and 'L' to me. I think the real reason that Pizza feels like it belongs in 'P' is because Pizza is the noun, and slice feels like a quantity, similar to "Pair of Boots" being in B.

I think a better rule in unique blank of whatever cases is to figure out which word is the noun, and which is the modifier. "Lantern of Shadows" belongs in L because Shadows describes the type of lantern you have, "Pair of Gloves" belongs in G because pair gives you a quantity of gloves. And "slice of pizza" belongs in P because slice tells you how much pizza you have.

As a bonus, this only involves the work of changing one case.

Edit: Though I guess this rule muddies the issue on items like centaur bardings, hmm...

(0028756)
wheals (administrator)
2015-04-01 16:58

Moved pizza to P. My view is that people usually call it "pizza," not "a slice" or anything else, so P is most logical (and people usually talk about !curing or ?amnesia etc.) That does have the same issue with bardings but screw it :P

- Issue History
Date Modified Username Field Change
2015-04-01 05:34 Glenstorm New Issue
2015-04-01 05:45 nicolae Note Added: 0028752
2015-04-01 05:46 nicolae Note Edited: 0028752
2015-04-01 05:48 nicolae Note Edited: 0028752
2015-04-01 06:00 Glenstorm Note Added: 0028753
2015-04-01 06:04 Glenstorm Note Edited: 0028753
2015-04-01 16:58 wheals Note Added: 0028756
2015-04-01 16:58 wheals Status new => resolved
2015-04-01 16:58 wheals Fixed in Branch => 0.17 development branch
2015-04-01 16:58 wheals Resolution open => done
2015-04-01 16:58 wheals Assigned To => wheals


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker