Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0009507 [DCSS] Bug Report minor have not tried 2015-02-25 22:45 2015-03-04 22:16
Reporter chris View Status public  
Assigned To wheals
Priority normal Resolution done  
Status resolved   Product Branch 0.16 ancient branch
Summary 0009507: Title cropping for long player names broken
Description 0.16-a0-1937-gb62f961 (Nov 2014, wheals) introduced bugs with long player names if title were to be cropped, namely "the" no longer being removed in the brief version, but code still calculating HUD sizes as though it were, and tacking a comma onto the title as well.
A diff illustrating that particular problem is attached (not as patch, since the bug should probably be tackled in a different way).

This regression was reported to the developer responsible for it multiple times over the past months with no apparent reaction from their end.

--

Another issue with console HUD and long names/titles is that for DGL builds, the message indicator will always overwrite seven chars (the length of "(Hit _)") even if no message is present, which is also not accounted for in other calculations, cf. update_message_status in output.cc: https://github.com/crawl-ref/crawl-ref/blob/master/crawl-ref/source/output.cc#L518 [^]

This results in output such as (player name: verylongnametest)

|                                   (Hit _) |
|verylongnam, the Victor of a Thousa        |


I hope this is fixable to only print the DGL message indicator if actual messages are present, and utilizing HUD redraw flags from output.cc to check when a title bar redraw needs to happen. If it's not, however, the available HUD width should be reduced by seven/eight chars for all respective calculations.
Additional Information
Tags No tags attached.
Attached Files ? file icon titlecrop.diff [^] (1,735 bytes) 2015-02-25 22:45 [Show Content]

- Relationships

-  Notes
(0028602)
wheals (administrator)
2015-03-04 22:16

OK, fixed (both, I think) in http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=01551211df5a. [^]

- Issue History
Date Modified Username Field Change
2015-02-25 22:45 chris New Issue
2015-02-25 22:45 chris File Added: titlecrop.diff
2015-03-04 22:16 wheals Note Added: 0028602
2015-03-04 22:16 wheals Status new => resolved
2015-03-04 22:16 wheals Fixed in Branch => 0.16 development branch
2015-03-04 22:16 wheals Resolution open => done
2015-03-04 22:16 wheals Assigned To => wheals
2015-03-04 22:16 wheals Fixed in Branch 0.16 development branch => longterm development (0.17+)


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker