|Anonymous | Login | Signup for a new account||2019-04-24 04:42 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0009495||[DCSS] Patches||feature||N/A||2015-02-19 02:31||2019-01-25 17:25|
|Status||new||Product Branch||0.16 ancient branch|
|Summary||0009495: <Monster> comes into view again|
https://crawl.develz.org/tavern/viewtopic.php?f=8&t=15182 [^] got support from many players so I created the patch.
It displays "<Monster> comes into view again" when a previously seen monster enters into LoS after being out of it.
Tested with manual exploration and with repeat command (using "0").
Please let me know if the patch can be accepted and what I should implement: bool option like "display_comes_into_view_again=false" or int option "turns_for_comes_into_view_again=-1" to avoid message spam (https://crawl.develz.org/tavern/viewtopic.php?f=8&t=15182&p=208266#p208266) [^]
|Tags||No tags attached.|
|Attached Files||turn_based_warning.patch [^] (7,634 bytes) 2015-02-20 03:00 [Show Content]|
edited on: 2015-02-19 02:37
Also tested with autoexplore. Autoexplore does not display the message but stops as expected.
I'd go with a turn counter probably, because of the spam issue. But that involves tracking when you last saw each monster.
Also, I'm not sure about making that set_auto_exclude... on the one hand, it's useful for things like electric eels in a big pool. On the other, it would be annoying to remove an exclusion on a stationary monster, only to have it come back the next time you explore or travel into the area.
edited on: 2015-02-19 03:51
I didn't add the set_auto_exclude, it was present in the code. I only removed the if-condition.
I will try to create the turn counter.
Edit. Oh, right, exclusion should not be created for "again".
Please use turn_based_warning.patch
First patch (0001-Display-Monster-comes-into-view-again-message.patch) can be ignored.
Default for turns_for_comes_into_view_again is -1 meaning that no message is displayed.
Tested with no option and with 6.
|Just wanted to remind about the patch, 0.16 has been released and active development of 0.17 is in progress as far as I know. Thank you.|
|Any hope to make it into the game?|
|2015-02-19 02:31||Sandman25||New Issue|
|2015-02-19 02:31||Sandman25||File Added: 0001-Display-Monster-comes-into-view-again-message.patch|
|2015-02-19 02:35||Sandman25||Note Added: 0028527|
|2015-02-19 02:37||Sandman25||Note Edited: 0028527|
|2015-02-19 02:42||neil||Note Added: 0028529|
|2015-02-19 03:12||Sandman25||Note Added: 0028530|
|2015-02-19 03:12||Sandman25||Note Edited: 0028530|
|2015-02-19 03:51||Sandman25||Note Edited: 0028530|
|2015-02-19 07:05||chris||Issue Monitored: chris|
|2015-02-20 03:00||Sandman25||File Added: turn_based_warning.patch|
|2015-02-20 03:01||Sandman25||Note Added: 0028536|
|2015-02-20 03:36||chris||File Deleted: 0001-Display-Monster-comes-into-view-again-message.patch|
|2015-04-21 20:25||Sandman25||Note Added: 0028950|
|2015-08-08 03:35||Sandman25||Note Added: 0029386|
|2019-01-25 17:25||ebering||Relationship added||related to 0004118|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|