Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0009269 [DCSS] Patches feature N/A 2014-11-28 05:25 2014-12-01 07:41
Reporter ebering View Status public  
Assigned To PleasingFungus
Priority normal Resolution done  
Status closed   Product Branch 0.16 ancient branch
Summary 0009269: Potion of Ambrosia
Description Suggested by PleasingFungus as a nice project. Has value/rarity the same as !cancellation in this patch, grants 3+random2(8) turns of Elixir regen and 3+random2(8) turns of confusion. The regen ends when it times out or when the player becomes not-confused, whichever is sooner.

This patch adds the item but doesn't put it back into vaults where ambrosia the food used to be, or anything like that.
Additional Information
Tags No tags attached.
Attached Files ? file icon ambrosia.patch [^] (10,653 bytes) 2014-11-28 05:25 [Show Content]
? file icon 01-ambrosia.patch [^] (85,052 bytes) 2014-11-29 00:50 [Show Content]
? file icon 02-ambrosia.patch [^] (74,358 bytes) 2014-11-30 18:13 [Show Content]

- Relationships

-  Notes
ebering (developer)
2014-11-28 06:07

Maybe not push this yet. I'd like to refactor and to stop using the potion_effect function and instead replace !confusion with !ambrosia

It's do it this way or do save compat since POT_CONFUSION is used in places that don't use potions >,: to confuse the player.
ebering (developer)
2014-11-29 00:54

Ok new version.

This is a series of patches that first re-factors potion_effect to not be used grossly all over the place where it really shouldn't be. Then replaces confusion with ambrosia (there's an intermediate patch in which they coexist), finally fixes up vaults that ask for confusion (this is separate from the confusion->ambrosia patch in case this blind switch isn't the best thing to do).
ebering (developer)
2014-11-30 18:14

Rebased to fix CRITICAL deficiencies in commit log/squash things where appropriate.
PleasingFungus (administrator)
2014-12-01 01:25

Pushed most of this. refactoring is sitting in a branch until I find someone who can help me figure out bizarre C++ inheritance issues.
PleasingFungus (administrator)
2014-12-01 06:30

Refactoring has been merged in, god help us all.

- Issue History
Date Modified Username Field Change
2014-11-28 05:25 ebering New Issue
2014-11-28 05:25 ebering File Added: ambrosia.patch
2014-11-28 06:07 ebering Note Added: 0027921
2014-11-29 00:50 ebering File Added: 01-ambrosia.patch
2014-11-29 00:54 ebering Note Added: 0027929
2014-11-30 18:13 ebering File Added: 02-ambrosia.patch
2014-11-30 18:14 ebering Note Added: 0027944
2014-12-01 01:25 PleasingFungus Note Added: 0027948
2014-12-01 01:25 PleasingFungus Status new => resolved
2014-12-01 01:25 PleasingFungus Fixed in Branch => 0.16 development branch
2014-12-01 01:25 PleasingFungus Resolution open => done
2014-12-01 01:25 PleasingFungus Assigned To => PleasingFungus
2014-12-01 06:30 PleasingFungus Note Added: 0027950
2014-12-01 07:41 ebering Status resolved => closed

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker