0009233: Crash when instakilling TSO summons - Dungeon Crawl Stone Soup Tracker

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0009233

[DCSS] Bug Report

crash

always

2014-11-20 03:09

2015-02-20 21:52

Reporter

PleasingFungus

View Status

public

Assigned To

neil

Priority

normal

Resolution

done

Status

resolved

Product Branch

0.16 ancient branch

Summary

0009233: Crash when instakilling TSO summons

Description

To reproduce:
(1) Use TSO's Divine Warrior ability to summon a pal.
(2) Kill it in a way that doesn't involve damage. &x^k works; possibly other approaches (distortion banishment, mangrove roots + confusion into deep water/lava...?) would as well.
(3) As the angel is in the midst of dying (that is, monster_die()), make_god_gifts_disappear() will be called, which will call monster_die() on the angel again. When it returns to the outer function, the monster type will be set to 1000 (invalid), which will cause a crash.

The right solution is probably to turn make_god_gifts_disappear() into a dact.

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0028541) neil (administrator) 2015-02-20 21:52	I fixed this in a lazier way (0.16-a0-4059-gb9776b0), by pretending the monster is already dead while firing conducts. A daction probably makes more sense, and would allow it to affect all levels, too.

Issue History
Date Modified	Username	Field	Change
2014-11-20 03:09	PleasingFungus	New Issue
2015-02-20 21:52	neil	Note Added: 0028541
2015-02-20 21:52	neil	Status	new => resolved
2015-02-20 21:52	neil	Fixed in Branch	=> 0.16 development branch
2015-02-20 21:52	neil	Resolution	open => done
2015-02-20 21:52	neil	Assigned To	=> neil

Mantis 1.1.8[^]