Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0009144 [DCSS] Patches tweak N/A 2014-11-06 01:10 2014-11-06 05:02
Reporter RBrandon View Status public  
Assigned To PleasingFungus
Priority normal Resolution done  
Status resolved   Product Branch 0.16 ancient branch
Summary 0009144: Implement skill-specific titling for Kiku and Nemelex
Description Kikubaaqudgha and Nemelex use Necromancy and Evocations for their abilities, respectively. I saw this as an opportunity (and it was suggested on tavern) to put some of the (practically) unused god titles to use. This patch overrides the skill title with a god title when the player's highest skill is Necromancy when worshiping Kiku and so on for Nemelex.

A note: the skill levels are a little "smashed" together, because the titles are normally meant for 7 piety breakpoints + penance. I used the 7 non-penance titles, one every 4 skill levels up to 20, one for 20-26 and one for level 27. These numbers could surely be tweaked, or one or more title(s) removed as needed.
Additional Information
Tags No tags attached.
Attached Files ? file icon 0001-Implement-skill-specific-titling-for-Kiku-and-Nemele.patch [^] (3,374 bytes) 2014-11-06 01:10 [Show Content]
? file icon Kiku-and-Nemelex-fixed.patch [^] (1,454 bytes) 2014-11-06 04:36 [Show Content]

- Relationships

-  Notes
wheals (administrator)
2014-11-06 03:25

I think it might be simpler, code-wise and for the player, to act like Invocations normally does and just give the title corresponding to your piety. This definitely looks cool though!
RBrandon (reporter)
2014-11-06 04:28

It definitely is simpler code-wise... I actually changed it FROM corresponding to piety because I had it in my head corresponding to skills :P It probably does make sense to simply use piety though. Even if it would be cool if training Evocations made you a Cardshark because flavour :)
RBrandon (reporter)
2014-11-06 04:40

Since it probably makes more sense that way, I uploaded an amended patch that chooses the title based on piety. So this patch only overrides Necro highest skill title for Kiku and Evo for Nem.

Also I realized I forgot to change the commit message but I read it again and it didn't go into the skill breakpoints anyway.
PleasingFungus (administrator)
2014-11-06 05:02

Pushed, thanks!

- Issue History
Date Modified Username Field Change
2014-11-06 01:10 RBrandon New Issue
2014-11-06 01:10 RBrandon File Added: 0001-Implement-skill-specific-titling-for-Kiku-and-Nemele.patch
2014-11-06 03:25 wheals Note Added: 0027671
2014-11-06 04:28 RBrandon Note Added: 0027672
2014-11-06 04:36 RBrandon File Added: Kiku-and-Nemelex-fixed.patch
2014-11-06 04:40 RBrandon Note Added: 0027673
2014-11-06 05:02 PleasingFungus Note Added: 0027674
2014-11-06 05:02 PleasingFungus Status new => resolved
2014-11-06 05:02 PleasingFungus Fixed in Branch => 0.16 development branch
2014-11-06 05:02 PleasingFungus Resolution open => done
2014-11-06 05:02 PleasingFungus Assigned To => PleasingFungus

Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker