Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0009098 [DCSS] Patches minor have not tried 2014-10-28 14:50 2014-11-26 04:19
Reporter chequers View Status public  
Assigned To wheals
Priority normal Resolution done  
Status resolved   Product Branch experimental branch
Summary 0009098: [PATCH] various webtiles-changes improvements
Description As previously suggested I'm moving to webtiles-changes for my (eventually arriving) public server. My repository is here:
https://github.com/alexjurkiewicz/crawl/tree/webtiles-changes [^]

You can add it as a remote to your own repo:
git remote add chequers https://github.com/alexjurkiewicz/crawl.git [^]
git fetch chequers
git cherry-pick d8248ed


Current commits ripe for the cherry picking:
230353f WebTiles: support (crappy, insecure) dgamelaunch-compatible password hashing
08c055e WebTiles: handle crypt.crypt failure
d8248ed WebTiles: allow specifying LANG for games
db4c118 WebTiles: check_config shouldn't cascade config.static_path errors
848eaa6 WebTiles: Add games.dir_path to config.toml.sample
e8edddc WebTiles: ensure config.static_path exists
2875966 WebTiles: change scan_titles to not modify global state so we can use it in check_config
2fcc53c config.toml -> config.toml.sample, and ignore config.toml

I'm around on IRC, hope to chat with the main webtiles-changes devs to get a better handle on your goals with the rewrite to see how I can help out and get these patches accepted.
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0027595)
neil (administrator)
2014-10-28 16:14

The bad password hashing was explicitly removed in webtiles-changes. Instead of re-adding that, you should use a patched dgamelaunch that supports decent salts. This commit makes dgl use SHA-256 by default (assuming GNU libc anyway). Old passwords with a bad salt will still verify, but new ones won't be generated:

https://github.com/neilmoore/dgamelaunch/commit/9a8c1531fc5a5a0d19700a6e10ade83521c90aff [^]

I'd also be careful about setting LANG. Webtiles builds of Crawl only support UTF-8 locales, so you should at least indicate that restriction in a comment.
(0027598)
chequers (reporter)
2014-10-28 21:35

re: password hashing. Thanks for the info. I've removed that commit and fixed documentation in the sample config file about 'broken'.

re: LANG support I wanted to run the webserver in whatever locale while still supporting dcss. Webserver runs fine in C locale, from my testing.
(0027897)
chequers (reporter)
2014-11-26 04:08

these have all been merged, thanks!

- Issue History
Date Modified Username Field Change
2014-10-28 14:50 chequers New Issue
2014-10-28 16:14 neil Note Added: 0027595
2014-10-28 21:35 chequers Note Added: 0027598
2014-11-26 04:08 chequers Note Added: 0027897
2014-11-26 04:19 wheals Status new => resolved
2014-11-26 04:19 wheals Fixed in Branch => 0.16 development branch
2014-11-26 04:19 wheals Resolution open => done
2014-11-26 04:19 wheals Assigned To => wheals


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker