Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0009034 [DCSS] Patches minor N/A 2014-10-09 05:10 2014-10-09 05:28
Reporter qoala View Status public  
Assigned To PleasingFungus
Priority normal Resolution done  
Status resolved   Product Branch 0.16 ancient branch
Summary 0009034: Initial documentation and cleanup of inventory selection code
Description 3 patches that can be applied or skipped independently of each other. Working my way through the existing options in the inventory prompt code before I start on adding a "select from ground" option as discussed on c-r-d.

0001: Defined SLOT_BARE_HANDS in terms of PROMPT_GET_SPECIAL, because the code currently assumes that prompt_invent_item returning the latter will select the former. Could alternatively add an explicit conversion instead?

0002: Fixed a doxygen comment that had "@params"

0003: Added a doxygen comment for prompt_invent_item. I think I figured out what all the arguments are for. (Also, @param count is currently unused?)
Additional Information
Tags No tags attached.
Attached Files ? file icon 20141008-0001-Define-one-special-constant-in-terms-of-another.patch [^] (1,038 bytes) 2014-10-09 05:10 [Show Content]
? file icon 20141008-0002-Fix-some-doxygen-tags.patch [^] (1,359 bytes) 2014-10-09 05:10 [Show Content]
? file icon 20141008-0003-Add-a-doxygen-comment-for-prompt_invent_item.patch [^] (3,339 bytes) 2014-10-09 05:11 [Show Content]

- Relationships

-  Notes
(0027457)
PleasingFungus (administrator)
2014-10-09 05:28

Checked and pushed, thanks!

- Issue History
Date Modified Username Field Change
2014-10-09 05:10 qoala New Issue
2014-10-09 05:10 qoala File Added: 20141008-0001-Define-one-special-constant-in-terms-of-another.patch
2014-10-09 05:10 qoala File Added: 20141008-0002-Fix-some-doxygen-tags.patch
2014-10-09 05:11 qoala File Added: 20141008-0003-Add-a-doxygen-comment-for-prompt_invent_item.patch
2014-10-09 05:28 PleasingFungus Note Added: 0027457
2014-10-09 05:28 PleasingFungus Status new => resolved
2014-10-09 05:28 PleasingFungus Fixed in Branch => 0.16 development branch
2014-10-09 05:28 PleasingFungus Resolution open => done
2014-10-09 05:28 PleasingFungus Assigned To => PleasingFungus


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker