Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0008463 [DCSS] Bug Report minor always 2014-04-29 02:33 2014-04-29 03:22
Reporter plaidman View Status public  
Assigned To wheals
Priority normal Resolution done  
Status closed   Product Branch 0.15 ancient branch
Summary 0008463: Ring of Shadows vs Dithmenos umbra inconsistencies
Description There are two inconsistent calculations for umbra radius and stealth bonuses.

In player.cc, lines 3916-3919 it's using the stealth bonus based on piety even if it's less than the bonus granted by Ring of Shadows.
        if (you_worship(GOD_DITHMENOS) || you_worship(GOD_YREDELEMNUL))
            stealth = stealth * (you.piety + MAX_PIETY) / MAX_PIETY;
        else if (player_equip_unrand(UNRAND_SHADOWS))
            stealth = stealth * 3 / 2;


However, in areas.cc, lines 717-725 it's using RoS if its radius is greater than the radius based on Dithmenos piety.
    if (religion == GOD_DITHMENOS && piety >= piety_breakpoint(0)
        && !penance[GOD_DITHMENOS])
    {
        // The cap is reached at piety 160 = ******.
        size = min(LOS_RADIUS*LOS_RADIUS + 1, piety * piety / 393);
    }

    if (player_equip_unrand(UNRAND_SHADOWS))
        size = max(size, 10);
Additional Information
Tags No tags attached.
Attached Files

- Relationships

-  Notes
(0025940)
wheals (administrator)
2014-04-29 02:50

Changed in trunk so it always uses the better boost to your umbra, both in terms of radius and stealth multiplier.
(0025942)
plaidman (reporter)
2014-04-29 03:21

Thanks for the quick fix!

- Issue History
Date Modified Username Field Change
2014-04-29 02:33 plaidman New Issue
2014-04-29 02:50 wheals Note Added: 0025940
2014-04-29 02:50 wheals Status new => resolved
2014-04-29 02:50 wheals Fixed in Branch => 0.15 development branch
2014-04-29 02:50 wheals Resolution open => done
2014-04-29 02:50 wheals Assigned To => wheals
2014-04-29 03:21 plaidman Note Added: 0025942
2014-04-29 03:21 plaidman Status resolved => closed


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker