|Anonymous | Login | Signup for a new account||2019-02-22 10:14 CET|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0008454||[DCSS] Bug Report||minor||always||2014-04-27 20:55||2014-04-30 14:14|
|Status||closed||Product Branch||0.15 ancient branch|
|Summary||0008454: When landing on a square with too many items to list, the glyphs of said items no longer print as a message|
Previous behavior was that landing on a square that had too many items to list as a message would instead list the glyphs. (this was very useful in being able to see at a glance if, for instance, there were corpses to sac or branded items, etc)
Now instead of listing the glyphs, there is just a message that says "There are many items here."
If this was an intentional change then please close this report but I don't see anything in the change log that makes me think it is. (and it would seem to be hiding useful info for no immediately obvious reason if so)
|Tags||No tags attached.|
|Ok, the deal is that you now always get the "There are many items here" prompt if there are exactly 4 items. Five or more prints the glyph list, three or fewer lists the items by name. (basically everything seems to be working as normal unless there are exactly 4 items)|
Hm... probably we should go into summary mode when there are too many lines for the message area, even if we haven't reached item_stack_summary_minimum.
Your message area is probably four lines high, and one line is needed for the "There are..." message.
edited on: 2014-04-29 15:06
Thanks neil...I just checked in game and my message area is actually six lines high.
edit: however, adding item_stack_summary_minimum = 4 to my rcfile did fix the problem
|The other thing that seems odd is that it seems like the number of items is being compared to the number of lines in the message area? This seems like kind of an impedance mismatch, since even 4 items still only takes up a single message line even when listing items by name instead of glyph. (And also the "There are..." message was getting printed even if it was the only message showing, so there were 4 or more empty lines below it)|
edited on: 2014-04-30 08:36
The problem is commit fcf2c25d (http://s-z.org/neil/git/?p=crawl.git;a=commitdiff;h=fcf2c25d3fde). [^] That indirectly sets the message window size of WebTiles games to 5, no matter what. That sets msgwin_lines() to 4 (because use_last_line() is generally false) and therefore
items.size() <= msgwin_lines() - 1is false for a stack of item size 4 (4 > 3).
I assume it is the way it is since it assumes a worst-case scenario for the length of an item description.
e: lowered default value of item_stack_summary_minimum, resolving
|2014-04-27 20:55||battaile||New Issue|
|2014-04-27 21:59||battaile||Note Added: 0025926|
|2014-04-27 22:03||battaile||Note Added: 0025927|
|2014-04-27 22:40||battaile||Note Added: 0025930|
|2014-04-29 07:39||battaile||Note Deleted: 0025926|
|2014-04-29 07:39||battaile||Note Deleted: 0025927|
|2014-04-29 07:39||battaile||Note Deleted: 0025930|
|2014-04-29 07:40||battaile||Note Added: 0025951|
|2014-04-29 08:41||neil||Note Added: 0025952|
|2014-04-29 14:08||battaile||Note Added: 0025962|
|2014-04-29 14:09||battaile||Note Deleted: 0025962|
|2014-04-29 14:10||battaile||Note Added: 0025963|
|2014-04-29 15:06||battaile||Note Edited: 0025963|
|2014-04-29 15:23||battaile||Note Added: 0025964|
|2014-04-30 08:32||wheals||Note Added: 0025981|
|2014-04-30 08:36||wheals||Note Edited: 0025981|
|2014-04-30 08:36||wheals||Status||new => resolved|
|2014-04-30 08:36||wheals||Fixed in Branch||=> 0.15 development branch|
|2014-04-30 08:36||wheals||Resolution||open => done|
|2014-04-30 08:36||wheals||Assigned To||=> wheals|
|2014-04-30 14:14||battaile||Status||resolved => closed|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|