Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0008421 [DCSS] Patches tweak have not tried 2014-04-23 06:20 2014-09-15 16:21
Reporter floatingatoll View Status public  
Assigned To wheals
Priority normal Resolution done  
Status resolved   Product Branch 0.15 ancient branch
Summary 0008421: melee_attack.cc: qty.3 of ASSERT(defender); to defend against static analysis null-pointer derefs
Description Clang's static analyzer indicates three possible paths where, given a null defender and various other circumstances, the 'defender' variable could be dereferenced unexpectedly.

(For instance, one requires the attacker to be a monster and a jumping attack, which is supposedly impossible.)

In typical play, it ought not be possible to trigger a null-pointer dereference at these locations. But someone points out that Windows doesn't stack trace on a non-ASSERT() coredump, so here's some ASSERT()s to help the chances of catching any future issues.
Additional Information
Tags No tags attached.
Attached Files ? file icon defender_defense.patch [^] (1,446 bytes) 2014-04-23 06:20 [Show Content]

- Relationships

-  Notes
(0027269)
wheals (administrator)
2014-09-15 16:21

Applied in 0.16-a0-460-g555ca3c, thanks!

- Issue History
Date Modified Username Field Change
2014-04-23 06:20 floatingatoll New Issue
2014-04-23 06:20 floatingatoll File Added: defender_defense.patch
2014-09-15 16:21 wheals Note Added: 0027269
2014-09-15 16:21 wheals Status new => resolved
2014-09-15 16:21 wheals Fixed in Branch => 0.16 development branch
2014-09-15 16:21 wheals Resolution open => done
2014-09-15 16:21 wheals Assigned To => wheals


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker