|
Viewing Issue Simple Details
[ Jump to Notes ]
[ Wiki ]
|
[ View Advanced ]
[ Issue History ]
[ Print ]
|
|
ID |
Category |
Severity |
Reproducibility |
Date Submitted |
Last Update |
|
0008356 |
[DCSS] Bug Report |
minor |
always |
2014-04-06 08:56 |
2014-04-06 09:00 |
|
|
Reporter |
PleasingFungus |
View Status |
public |
|
|
Assigned To |
wheals |
|
Priority |
normal |
Resolution |
done |
|
|
Status |
resolved |
|
Product Branch |
0.16 ancient branch |
|
|
Summary |
0008356: Lava orcs are always lava-immune, even in non-lava-immune forms |
|
Description |
E.g. lich, fungus, pig.
The culprit is player_likes_lava(), which is subtly wrong. It ends up only checking the species, which means that lava orcs are always safe in lava, regardless of their current form. It would also be bugged in the case of non-lava orc species polymorphed into a lava-safe form; thankfully, as far as I'm aware, there are none...
I've attached a patch that should fix these critical issues, while keeping the current behavior in cases where it's intended - ice & statue form, which have special case code to melt back into lava orcs. |
|
Additional Information |
|
| Tags |
No tags attached. |
|
|
Attached Files |
 0001-Fix-lava-orc-form-check-code.patch [^] (1,762 bytes) 2014-04-06 08:56 [Show Content] [Hide Content]From cf3dd6e1d7680d73a65d274e8a33ce2fbf47aa9b Mon Sep 17 00:00:00 2001
From: Nicholas Feinberg <pleasingfung@gmail.com>
Date: Sat, 5 Apr 2014 23:35:12 -0700
Subject: [PATCH] Fix lava orc form check code
The code in player_likes_lava() was subtly wrong, with the result that
transformed lava orcs were always able to enter lava. This restores what
appears to have been the intended behavior.
---
crawl-ref/source/player.cc | 4 ++--
crawl-ref/source/transform.cc | 5 ++++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/crawl-ref/source/player.cc b/crawl-ref/source/player.cc
index b09955c..4525a77 100644
--- a/crawl-ref/source/player.cc
+++ b/crawl-ref/source/player.cc
@@ -525,8 +525,8 @@ bool player_likes_water(bool permanently)
bool player_likes_lava(bool permanently)
{
- return species_likes_lava(you.species)
- || (!permanently && form_likes_lava());
+ return (species_likes_lava(you.species) || !permanently)
+ && form_likes_lava();
}
bool player_can_open_doors()
diff --git a/crawl-ref/source/transform.cc b/crawl-ref/source/transform.cc
index aabe0fd..2213f8e 100644
--- a/crawl-ref/source/transform.cc
+++ b/crawl-ref/source/transform.cc
@@ -134,8 +134,11 @@ bool form_likes_water(transformation_type form)
bool form_likes_lava(transformation_type form)
{
// Lava orcs can only swim in non-phys-change forms.
+ // However, ice beast & statue form will melt back to lava, so they're OK
return you.species == SP_LAVA_ORC
- && !form_changed_physiology(form);
+ && (!form_changed_physiology(form)
+ || form == TRAN_ICE_BEAST
+ || form == TRAN_STATUE);
}
bool form_can_butcher(transformation_type form)
--
1.8.5.2 (Apple Git-48)
|
|
|
