|Anonymous | Login | Signup for a new account||2019-04-23 22:42 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0008356||[DCSS] Bug Report||minor||always||2014-04-06 08:56||2014-04-06 09:00|
|Status||resolved||Product Branch||0.16 ancient branch|
|Summary||0008356: Lava orcs are always lava-immune, even in non-lava-immune forms|
E.g. lich, fungus, pig.
The culprit is player_likes_lava(), which is subtly wrong. It ends up only checking the species, which means that lava orcs are always safe in lava, regardless of their current form. It would also be bugged in the case of non-lava orc species polymorphed into a lava-safe form; thankfully, as far as I'm aware, there are none...
I've attached a patch that should fix these critical issues, while keeping the current behavior in cases where it's intended - ice & statue form, which have special case code to melt back into lava orcs.
|Tags||No tags attached.|
|Attached Files||0001-Fix-lava-orc-form-check-code.patch [^] (1,762 bytes) 2014-04-06 08:56 [Show Content]|
|2014-04-06 08:56||PleasingFungus||New Issue|
|2014-04-06 08:56||PleasingFungus||File Added: 0001-Fix-lava-orc-form-check-code.patch|
|2014-04-06 09:00||wheals||Note Added: 0025789|
|2014-04-06 09:00||wheals||Status||new => resolved|
|2014-04-06 09:00||wheals||Fixed in Branch||=> 0.14 development branch|
|2014-04-06 09:00||wheals||Resolution||open => done|
|2014-04-06 09:00||wheals||Assigned To||=> wheals|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|