Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0008265 [DCSS] Patches feature N/A 2014-03-12 02:30 2014-03-13 09:09
Reporter Lasty View Status public  
Assigned To gammafunk
Priority normal Resolution done  
Status resolved   Product Branch 0.14 ancient branch
Summary 0008265: Allow players to memorize spells even when fail rate is >= 100%
Description Allow players to memorize spells even when fail rate is >= 100%.

This didn't add anything beneficial, since there were several silly workarounds, including taking off armour, quaffing brilliance, putting on +wiz / +int rings, etc. when you wanted to learn a spell that you couldn't yet even remotely cast.
Additional Information
Tags No tags attached.
Attached Files ? file icon diff.patch [^] (542 bytes) 2014-03-12 02:30 [Show Content]
? file icon final diff.patch [^] (1,024 bytes) 2014-03-12 02:59 [Show Content]

- Relationships

-  Notes
(0025571)
Lasty (developer)
2014-03-12 02:58

Added a new version of the patch which changes the warning on memorization from "This spell is very dangerous to cast!" to "This spell is impossible to cast!" when the spell is at failure 100% or greater.
(0025572)
Lasty (developer)
2014-03-12 03:03

Please delete or ignore revised diff.patch. It's broken and I don't have permission to delete it.
(0025588)
gammafunk (administrator)
2014-03-13 09:09

A patch based on this was pushed in 0.14-a0-3292-g6b74f42, thanks! Also, your diff had trailing whitespace on lines 23 and 24. You can run the util/checkwhite script from the source directory to check all files for any whitespace and remove it (it gives you notification), and also configure your text editor to not let you do have trailing whitespace for source code files.

- Issue History
Date Modified Username Field Change
2014-03-12 02:30 Lasty New Issue
2014-03-12 02:30 Lasty File Added: diff.patch
2014-03-12 02:57 Lasty File Added: revised diff.patch
2014-03-12 02:58 Lasty Note Added: 0025571
2014-03-12 02:59 Lasty File Added: final diff.patch
2014-03-12 03:03 Lasty Note Added: 0025572
2014-03-12 17:35 MarvinPA File Deleted: revised diff.patch
2014-03-13 09:09 gammafunk Note Added: 0025588
2014-03-13 09:09 gammafunk Status new => resolved
2014-03-13 09:09 gammafunk Fixed in Branch => 0.14 development branch
2014-03-13 09:09 gammafunk Resolution open => done
2014-03-13 09:09 gammafunk Assigned To => gammafunk


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker