mon-abil.cc:5127:50: warning: while loop has empty body [-Wempty-body]
while (ray.advance() && ray.pos() != *di);
^
mon-abil.cc:5127:50: note: put the semicolon on a separate line to silence this warning
Which correctly identifies that there is something resembling a typo'd while loop in the code:
while (ray.advance() && ray.pos() != *di);
{
if (!map_bounds(ray.pos()))
break;
}
As written with the semicolon, it iterates over ray.advance() until exhausted, then does a single check of map_bounds(ray.pos) and breaks out of the distance_iterator for loop.
It seems likely that this was intended to break out of the while loop, implying that the semicolon should be removed.
Removing the semicolon clears the warnings. I'm not familiar with this code, so I don't know how to test the before/after behavior properly.
throw_raypath_while.patch [^] (487 bytes) 2014-03-10 03:20 [Show Content]
