Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0008187 [DCSS] Bug Report minor random 2014-02-21 17:21 2018-08-18 18:10
Reporter johnnyzero View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Branch 0.14 ancient branch
Summary 0008187: Unlinked temporary items after defeating orc band
Description After defeating an orc band, I received the following warning text in-game.

 Unlinked temporary item:
 amulet of resist mutation
     item 0000160:  base: 6; sub: 43; plus: 0; plus2: 0; special: 5
     quant: 1; colour: 6; ident: 0x0000000f; ident_type: 4
     x: 0; y: 0; link: 27000
 Unlinked item held by dead monster:
 orcish war axe
     item 0000178:  base: 0; sub: 19; plus: 1; plus2: 0; special: 0
     quant: 1; colour: 5; ident: 0x01000000; ident_type: 0
     x: -2; y: -2; link: 27008
 Unlinked item held by dead monster:
 orcish leather armour
     item 0000179:  base: 2; sub: 1; plus: 2; plus2: 0; special: 0
     quant: 1; colour: 6; ident: 0x01000000; ident_type: 0
     x: -2; y: -2; link: 27008


This warning text now triggers when entering the level (Vaults:4) and persists across saves. I used some combination of freezing cloud, spectral weapon, and melee to dispose of the band.

Save: https://dobrazupa.org/saves/johnnyzero-crawl-git-b10a4c8224-140221-1616.tar.bz2 [^]

Note: I transferred the save to 0.14-a0-2737-gb10a4c8 and the warning still exists.
Additional Information
Tags No tags attached.
Attached Files zip file icon save data from BNeutral.zip [^] (3,200,446 bytes) 2017-09-15 05:43

- Relationships
has duplicate 0008926closedneil Unlinked item held by dead monster 
has duplicate 0008929closedneil Unknown Beogh problem 
has duplicate 0009225closedneil debug(?) message "unlinked item held by dead monster" when entering level 
has duplicate 0009632closedneil Mysteriously revived Beogh follower causes "Unlinked item held by dead monster" error 
has duplicate 0010059closedwheals error msg: unlinked item held by monster 
has duplicate 0010066resolvedwheals Item linking bug when entering a level as HO of Beogh 
has duplicate 0010196resolvedMedar Unlinked item 
has duplicate 0010559resolvedPleasingFungus Unlinked item(dropped orc weapon) 
has duplicate 0010593resolvedPleasingFungus (Beogh) 'Unlinked item held by dead monster' message 
has duplicate 0011176closed Mysterious messages in Shoals 
has duplicate 0011621resolvedadvil "Unlinked item held by dead monster" 
related to 0011413new Unlinked temporary item: uncursed triple crossbow 

-  Notes
(0025508)
johnnyzero (reporter)
2014-03-07 18:26
edited on: 2014-03-07 18:27

Encountered this again in 0.14-a0-3127-g5fcec12. Another orc with jewellery.
 You feel a surge of power! The flame hits the orc wizard.
 You kill the orc wizard!
 Unlinked item held by dead monster:
 robe
     item #1:  base: 2; sub: 0; plus: 0; plus2: 0; special: 0
     quant: 1; colour: 4; ident: 0x00000100; ident_type: 0
     x: -2; y: -2; link: 27084
 Unlinked item held by dead monster:
 whip
     item 0000006:  base: 0; sub: 1; plus: 0; plus2: 0; special: 0
     quant: 1; colour: 7; ident: 0x00000000; ident_type: 0
     x: -2; y: -2; link: 27084
 Unlinked item held by dead monster:
 shield
     item 0000053:  base: 2; sub: 13; plus: 0; plus2: 0; special: 0
     quant: 1; colour: 3; ident: 0x00000000; ident_type: 0
     x: -2; y: -2; link: 27084
 Unlinked item held by dead monster:
 ring of protection
     item 0000054:  base: 6; sub: 1; plus: -3; plus2: 0; special: 16
     quant: 1; colour: 7; ident: 0x00000100; ident_type: 4
     x: -2; y: -2; link: 27084
 Item cursed -3 ring of protection claims to be held by monster DEAD MONSTER,
 but it isn't in the monster's inventory.

Save: https://dobrazupa.org/saves/johnnyzero-crawl-git-5fcec126f3-140307-1721.tar.bz2 [^]

(0027102)
johnnyzero (reporter)
2014-08-29 06:38

Still getting these errors occasionally when dealing orcs in 0.16-a0-296-gbdb9f68. It seems to trigger when I gift an orc wizard a new weapon via Beogh's ability. Perhaps in the older versions it was due to orc wizards picking up items off the floor?

 You climb downwards.
 Unlinked item held by dead monster:
 runed hand axe
     item 0000125:  base: 0; sub: 18; plus: -2; plus2: 0; special: 0
     quant: 1; colour: 5; ident: 0x20020100; ident_type: 0
_    x: -2; y: -2; link: 27010
 There is a stone staircase leading up here.

 Unlinked item held by dead monster:
 trident
     item 0000005:  base: 0; sub: 24; plus: 0; plus2: 0; special: 0
     quant: 1; colour: 4; ident: 0x20000100; ident_type: 0
_    x: -2; y: -2; link: 27034


Save: https://dobrazupa.org/saves/johnnyzero-crawl-git-1ba5a8cb38-140828-0434.tar.bz2 [^]
Later save (same game, separate instance): https://dobrazupa.org/saves/johnnyzero-crawl-git-bdb9f68cb4-140829-0435.tar.bz2 [^]
(0027171)
stickyfingers (reporter)
2014-09-07 15:16

I also had this problem, though in 0.15 (0.15.0-18-g9076a4f):

Unlinked item held by dead monster:
embroidered robe
    item 0000003: base: 2; sub: 0; plus: 1; plus2: 0; special: 17
    quant: 1; colour: 4; ident: 0x20040000; ident_type: 0
    x: -2; y: -2; link: 27021
Unlinked item held by dead monster:
ring of protection
    item 0000012: base: 6; sub: 1; plus: 5; plus2: 0; special: 25
    quant: 1; colour: 6; ident: 0x20000000; ident_type: 4
    x: -2; y: -2; link: 27021
Unlinked item held by dead monster:
shiny buckler
    item 0000023: base: 2; sub: 12; plus: 2; plus2: 0; special: 16
    quant: 1; colour: 3; ident: 0x20040000; ident_type: 0
    x: -2; y: -2; link: 27021
Unlinked item held by dead monster:
bone broad axe
    item 0000045: base: 0; sub: 20; plus: 10; plus2: 0; special: 0
    quant: 1; colour: 10; ident: 0x20001000; ident_type: 0
    x: -2; y: -2; link: 27021
Item +5 ring of protection claims to be held by monster DEAD MONSTER, but it isn't in the monster's inventory.

http://crawl.lantea.net/saves//stickyfingers-crawl-0.15-140907-1309.tar.bz2 [^]
(0028683)
johnnyzero (reporter)
2015-03-22 02:06

Blew up a deep elf priest and encountered this issue yet again (0.17-a0-119-g2b06fc5). Looks like the monster had some floor equipment.

 You feel a surge of power! The fireball explodes!
 The fireball engulfs the deep elf priest.
 You kill the deep elf priest!
 Unlinked item held by dead monster:
 uncursed shortbow
     item 0000247:  base: 0; sub: 30; plus: 0; plus2: 0; special: 0
     quant: 1; ident: 0x20000003; ident_type: 0
     x: -2; y: -2; link: 27108
 Unlinked item held by dead monster:
 uncursed scimitar
     item 0000248:  base: 0; sub: 16; plus: 0; plus2: 0; special: 0
     quant: 1; ident: 0x20000003; ident_type: 0
     x: -2; y: -2; link: 27108
 Unlinked item held by dead monster:
 15 arrows
     item 0000249:  base: 1; sub: 2; plus: 0; plus2: 0; special: 0
     quant: 15; ident: 0x20000002; ident_type: 0
     x: -2; y: -2; link: 27108
 Unlinked item held by dead monster:
 ring of protection from magic
     item 0000335:  base: 6; sub: 20; plus: 0; plus2: 0; special: 288
     quant: 1; ident: 0x20000000; ident_type: 4
     x: -2; y: -2; link: 27108
 Item ring of protection from magic claims to be held by monster DEAD MONSTER,
 but it isn't in the monster's inventory.


https://dobrazupa.org/saves/johnnyzero-crawl-git-2b06fc5f79-150321-0348.tar.bz2 [^]
(0029135)
neil (administrator)
2015-06-06 01:51

If this happens with Ashenzari, it's 0008430. With Beogh it is this bug. Otherwise, 0007983.
(0029747)
Medar (developer)
2015-11-07 00:08

Unlinked item held by dead monster:
 enchanted trident
     item 0000039: base: 0; sub: 24; plus: -1; plus2: 0; special: 0
     quant: 1; ident: 0x20020102; ident_type: 0
_ x: -2; y: -2; link: 27016
_There is a stone staircase leading down here.
_You climb downwards.
_There is a stone staircase leading up here.
_There is a stone staircase leading down here.
 You climb downwards.
 Unlinked item held by dead monster:
 enchanted trident
     item 0000039: base: 0; sub: 24; plus: -1; plus2: 0; special: 0
     quant: 1; ident: 0x20020102; ident_type: 0
_ x: -2; y: -2; link: 27016
 There is a stone staircase leading up here.

http://CRAWL.XTAHUA.COM/saves/Medar-crawl-0.17-151106-2308.tar.bz2 [^]
(0030205)
Floodkiller (reporter)
2016-02-19 04:58
edited on: 2016-02-19 04:59

Encountered after having cleared, exited, and re-entered Orc:1 a couple times. Worshipping Beogh.

There is a staircase to the Orcish Mines here.
 You climb downwards. Welcome to the Orcish Mines!
 Unlinked item held by dead monster:
 battleaxe
     item 0000056: base: 0; sub: 21; plus: 0; plus2: 0; special: 0
     quant: 1; ident: 0x20000102; ident_type: 0
_ x: -2; y: -2; butt: 27007
 There butts a staircase back to the Dungeon here.

http://dobrazupa.org/saves/Floodkiller-20160218.tar.bz2 [^]

(0031543)
Esc (reporter)
2017-03-10 11:49

Worshipping Beogh. Version 0.20-a0-850-ge5a7832.
Cleared Spider Nest and got this when I went up stairs:

 Unlinked item held by dead monster:
 trident
     item #0: base: 0; sub: 24; plus: 0; plus2: 0; special: 0
     quant: 1; ident: 0x20000102; ident_type: 0
_ x: -2; y: -2; link: 27001

http://CRAWL.XTAHUA.COM/saves/esc-crawl-git-e5a7832000-170310-1045.tar.bz2 [^]
(0031833)
BNeutral (reporter)
2017-09-15 05:48
edited on: 2017-09-15 05:49

Worshipper of Beoght.
Crawl version 0.20.1
Save file version 34.187
Compiled with GCC 6.3.0 20170628
Build platform: x86_64-linux-gnu

Message reads:
Unlinked item held by dead monster:
 scale mail
     item 0000035: base: 2; sub: 3; plus: 0; plus2: 0; special: 0
     quant: 1; ident: 0x20000100; ident_type: 0
_ x: -2; y: -2; link: 27183

It pops up whenever I go into a certain level of the lair. However, it started happening after I cleared some completely unrelated area.
Save data attached.

(0032562)
advil (administrator)
2018-08-18 18:10
edited on: 2018-08-18 18:13

I believe I have finally tracked down the Beogh version of this and fixed it in: https://github.com/crawl/crawl/commit/33897af1d260 [^]

Commit message excerpt:
The problem was with named followers who had been gifted items.  What
was happening was that both drop_item and take_item could fail, but
beogh_gift_item() didn't check for these fail conditions and forced the
gift on the follower regardless. If the follower had an old item in the
relevant slot, this left the old item still associated with the follower
but unlinked, and errors started showing up when the follower died and
the item didn't get properly converted to a floor item. The main case
where this came up was if you gifted a follower an item and the item
they already had in that slot was cursed, causing drop_item to fail. The
key symptom (which is rather hard to notice) is that the follower
wouldn't generate a drop message for the old item. I have changed things
so that Beogh removes the curse in these cases, so that the follower can
drop their cursed item.  Alternatively, the gift could just fail, but
this harsher behavior didn't seem to me to contribute anything
interesting to gameplay.


This fix prevents the bug happening but doesn't impact the later error messages. A change I added a few months ago ( https://github.com/crawl/crawl/commit/29664b41f07d [^] ) does fix the error messages up on save+load; I don't think any more save compat than this is needed.

This isn't the sort of mantis bug you just close, so I'll leave this open for a while and see how it goes, but every save on mantis I've tested that is a Beogh game is consistent with the fix. There are still other variants in the wild, in particular there's still a Dith version that seems to be unrelated in terms of cause, as far as I could see: 0011413


- Issue History
Date Modified Username Field Change
2014-02-21 17:21 johnnyzero New Issue
2014-03-07 18:26 johnnyzero Note Added: 0025508
2014-03-07 18:27 johnnyzero Note Edited: 0025508
2014-08-29 06:38 johnnyzero Note Added: 0027102
2014-09-05 22:13 wheals Relationship added related to 0008926
2014-09-07 00:47 doy Relationship added related to 0008929
2014-09-07 15:16 stickyfingers Note Added: 0027171
2015-03-22 02:06 johnnyzero Note Added: 0028683
2015-06-06 01:51 neil Note Added: 0029135
2015-06-06 01:53 neil Relationship added has duplicate 0009225
2015-06-06 01:57 neil Relationship added has duplicate 0009632
2015-06-06 01:58 neil Relationship replaced has duplicate 0008929
2015-06-06 01:59 neil Relationship replaced has duplicate 0008926
2015-11-07 00:08 Medar Note Added: 0029747
2015-11-10 17:12 wheals Relationship added has duplicate 0010059
2015-11-10 17:24 wheals Relationship added has duplicate 0010066
2015-12-23 09:40 Medar Relationship added has duplicate 0010196
2016-02-19 04:58 Floodkiller Note Added: 0030205
2016-02-19 04:59 Floodkiller Note Edited: 0030205
2016-08-03 17:46 PleasingFungus Relationship added has duplicate 0010559
2016-08-03 17:46 PleasingFungus Relationship added has duplicate 0010593
2017-03-10 11:49 Esc Note Added: 0031543
2017-08-08 01:45 advil Relationship added has duplicate 0011176
2017-09-15 05:43 BNeutral File Added: save data from BNeutral.zip
2017-09-15 05:48 BNeutral Note Added: 0031833
2017-09-15 05:49 BNeutral Note Edited: 0031833
2017-09-15 05:49 BNeutral Note Edited: 0031833
2017-09-15 05:50 BNeutral Issue Monitored: BNeutral
2018-04-12 03:51 advil Relationship added related to 0011413
2018-08-16 23:41 advil Relationship added has duplicate 0011621
2018-08-18 18:10 advil Note Added: 0032562
2018-08-18 18:13 advil Note Edited: 0032562


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker