Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0008184 [DCSS] Patches feature N/A 2014-02-21 05:26 2014-06-23 06:02
Reporter Sage View Status public  
Assigned To MarvinPA
Priority normal Resolution done  
Status resolved   Product Branch 0.14 ancient branch
Summary 0008184: Better ring swapping.
Description When putting on a ring and you are already wearing as many rings as you can, if the ring you are putting on matches a ring you are already wearing, a ring that doesn't match is removed without prompting.
Additional Information
Tags No tags attached.
Attached Files ? file icon ring-swap.patch [^] (4,079 bytes) 2014-02-21 05:26 [Show Content]
? file icon ring-swap-update.patch [^] (4,212 bytes) 2014-02-21 12:29 [Show Content]
? file icon ring-swap-initfile-update.patch [^] (5,963 bytes) 2014-02-21 13:21 [Show Content]

- Relationships

-  Notes
(0025348)
Sage (reporter)
2014-02-21 05:44

To do: Add efficient_swapping rc option; false disables this and autoswapping when you have two identical rings.
(0025349)
Sage (reporter)
2014-02-21 12:33

Fixed a bug that prevented automatic swapping from working when you are wearing two identical rings and swapping to another identical ring. On another note, I believe I fixed issue 8062; the original check to see if the rings were identical only checked if one of the rings was an artefact, so I added another check for the other ring.
(0025350)
Sage (reporter)
2014-02-21 13:22

The third patch also adds a boolean initfile option to enable or disable both kinds of automatic ring swapping, fast_ring_swap. It defaults to false.
(0026606)
MarvinPA (developer)
2014-06-23 06:02

This seems to have been merged at some point or other.

- Issue History
Date Modified Username Field Change
2014-02-21 05:26 Sage New Issue
2014-02-21 05:26 Sage File Added: ring-swap.patch
2014-02-21 05:44 Sage Note Added: 0025348
2014-02-21 12:29 Sage File Added: ring-swap-update.patch
2014-02-21 12:33 Sage Note Added: 0025349
2014-02-21 13:21 Sage File Added: ring-swap-initfile-update.patch
2014-02-21 13:22 Sage Note Added: 0025350
2014-06-23 06:02 MarvinPA Note Added: 0026606
2014-06-23 06:02 MarvinPA Status new => resolved
2014-06-23 06:02 MarvinPA Fixed in Branch => 0.15 development branch
2014-06-23 06:02 MarvinPA Resolution open => done
2014-06-23 06:02 MarvinPA Assigned To => MarvinPA


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker