|Anonymous | Login | Signup for a new account||2019-04-24 06:47 CEST|
|Main | My View | View Issues | Change Log | Wiki | Tavern | News|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0008095||[DCSS] Patches||feature||N/A||2014-02-03 14:53||2014-02-03 21:01|
|Status||resolved||Product Branch||0.14 ancient branch|
|Summary||0008095: Automatically identify chopped dragon and troll hides.|
Originally reported by duvessa here:
This patch automatically identifies dragon and troll hides as they are generated. These items are always generated +0 and uncursed yet retain their "unidentified" status even after they are made into dragon armour. As a result, the player has to go through needless step of equipping dragon armour or using a scroll of identify on it prior to using that armour to open a trove.
Always identifying chopped hides wouldn't affect the value of ?identify at all for spoiled players (they already know these things generate at +0), and it would remove one pointless step of tedium from the game, so here we are.
Alternative solutions to this problem would be for troves to accept unidentified items or for hides to generate with random bonuses, but this seems like a simple enough fix.
|Tags||No tags attached.|
|Attached Files||0001-Automatically-identify-chopped-hides.patch [^] (1,241 bytes) 2014-02-03 14:53 [Show Content]|
|This should be applied, in my opinion.|
|It would be even better to also not show the +0, since it is irrelevant.|
|In trunk (0.14-a0-2403-g3e27d54), thanks! I removed the set_ident_type call (it does nothing for armour), also pre-identified hides generated on the floor (0.14-a0-2404-ge212a54), and took galehar's suggestion to not even show the +0 (0.14-a0-2405-gb782f2d).|
edited on: 2014-02-03 21:10
Fixed to only omit +0; hides can get to -1 or lower through corrosion, which carries over to the armour they are transformed into, so show that. It probably happens only rarely, though.
|2014-02-03 14:53||Implojin||New Issue|
|2014-02-03 14:53||Implojin||File Added: 0001-Automatically-identify-chopped-hides.patch|
|2014-02-03 14:55||dpeg||Note Added: 0025187|
|2014-02-03 15:57||galehar||Note Added: 0025188|
|2014-02-03 18:15||neil||Note Added: 0025189|
|2014-02-03 18:15||neil||Status||new => resolved|
|2014-02-03 18:15||neil||Fixed in Branch||=> 0.14 development branch|
|2014-02-03 18:15||neil||Resolution||open => done|
|2014-02-03 18:15||neil||Assigned To||=> neil|
|2014-02-03 21:01||neil||Note Added: 0025192|
|2014-02-03 21:10||neil||Note Edited: 0025192|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|