Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007921 [DCSS] Patches text N/A 2013-12-27 17:24 2014-01-28 00:42
Reporter wheals View Status public  
Assigned To neil
Priority normal Resolution done  
Status closed   Product Branch 0.14 ancient branch
Summary 0007921: Make base attack delay be a decimal.
Description There doesn't seems to be any good reason for it to be a percentage, and i have seen nobody ever quote delays in terms of percentages. In case the player's movespeed isn't 10 aut, it might even be potentially confusing to someone who thinks that the weapon is proprtionally slower too.
Additional Information
Tags No tags attached.
Attached Files ? file icon 0001-Make-base-attack-delay-be-displayed-as-a-decimal-ins.patch [^] (1,455 bytes) 2013-12-27 17:24 [Show Content]
? file icon 0001-Display-minimum-delay-in-a-weapon-s-description.patch [^] (4,542 bytes) 2013-12-27 18:24 [Show Content]

- Relationships

-  Notes
(0024854)
wheals (administrator)
2013-12-27 18:24

ChrisOelmueller suggested on IRC that mindelay be added to the weapon display screen. The second patch attached does so.
(0024855)
neil (administrator)
2013-12-27 19:14

Both applied in trunk (0.14-a0-1654-ga75cc6c and 0.14-a0-1655-g28267cd), thanks! I made some changes to the second commit: renamed the function to weapon_min_delay, moved it to fight.cc, and made the parameter a const reference instead of a value.

- Issue History
Date Modified Username Field Change
2013-12-27 17:24 wheals New Issue
2013-12-27 17:24 wheals File Added: 0001-Make-base-attack-delay-be-displayed-as-a-decimal-ins.patch
2013-12-27 18:24 wheals File Added: 0001-Display-minimum-delay-in-a-weapon-s-description.patch
2013-12-27 18:24 wheals Note Added: 0024854
2013-12-27 19:14 neil Note Added: 0024855
2013-12-27 19:14 neil Status new => resolved
2013-12-27 19:14 neil Fixed in Branch => 0.14 development branch
2013-12-27 19:14 neil Resolution open => done
2013-12-27 19:14 neil Assigned To => neil
2014-01-28 00:42 wheals Issue Monitored: wheals
2014-01-28 00:42 wheals Status resolved => closed


Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker